-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TimingModel.params
and TimingModel.ordered_params
identical.
#1617
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1617 +/- ##
==========================================
- Coverage 68.14% 68.14% -0.01%
==========================================
Files 98 98
Lines 22660 22658 -2
Branches 3893 3892 -1
==========================================
- Hits 15442 15440 -2
Misses 6264 6264
Partials 954 954
☔ View full report in Codecov by Sentry. |
Would it be better to just remove the |
I think we should keep it for the time being since other people's codes may depend on it. We can deprecate it and then remove it in the future once people get enough time to change their code. |
OK, I think I can merge this when you are done. |
I am done. |
See #1295
These parameter lists had different orders because Python dicts were unordered until Python 3.7. Since this is no longer the case,
TimingModel.params
andTimingModel.ordered_params
have no reason to be different anymore.