Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TimingModel.params and TimingModel.ordered_params identical. #1617

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

abhisrkckl
Copy link
Contributor

See #1295

These parameter lists had different orders because Python dicts were unordered until Python 3.7. Since this is no longer the case, TimingModel.params and TimingModel.ordered_params have no reason to be different anymore.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: -0.01% ⚠️

Comparison is base (dc40e8b) 68.14% compared to head (18f4604) 68.14%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
- Coverage   68.14%   68.14%   -0.01%     
==========================================
  Files          98       98              
  Lines       22660    22658       -2     
  Branches     3893     3892       -1     
==========================================
- Hits        15442    15440       -2     
  Misses       6264     6264              
  Partials      954      954              
Files Changed Coverage Δ
src/pint/models/timing_model.py 83.57% <75.00%> (-0.03%) ⬇️
src/pint/fitter.py 84.05% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlakaplan
Copy link
Contributor

Would it be better to just remove the ordered_params and make all instances params?

@abhisrkckl
Copy link
Contributor Author

abhisrkckl commented Aug 17, 2023

I think we should keep it for the time being since other people's codes may depend on it. We can deprecate it and then remove it in the future once people get enough time to change their code.

@dlakaplan
Copy link
Contributor

OK, I think I can merge this when you are done.

@abhisrkckl
Copy link
Contributor Author

I am done.

@dlakaplan dlakaplan merged commit c6b2c82 into nanograv:master Aug 17, 2023
@abhisrkckl abhisrkckl deleted the param-order branch August 18, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The order of parameters in TimingModel.free_params and TimingModel.designmatrix is different
2 participants