-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of WaveX model #1609
Addition of WaveX model #1609
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1609 +/- ##
========================================
Coverage 68.25% 68.26%
========================================
Files 99 100 +1
Lines 22806 23108 +302
Branches 3920 4009 +89
========================================
+ Hits 15567 15774 +207
- Misses 6276 6343 +67
- Partials 963 991 +28
☔ View full report in Codecov by Sentry. |
I have merged David's RTD fix PR. Can you merge the master here? |
tests/test_wavex.py
Outdated
from io import StringIO | ||
import pytest | ||
import numpy as np | ||
import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using logging, it's better to use loguru since that's what the rest of pint uses.
Hi.. I see that the patch coverage is only 63%. Can you make sure that it's at least 70%? |
models/wavex.py
) as a timing modelDelayComponent
with parameters:WXEPOCH
(MJDParameter): reference epoch either set by user or copied fromPEPOCH
- frozenWXFREQ_000X
(prefixParameter) [days^-1]: Wave frequencies set by user with integer label X - frozenWXSIN_000X
(prefixParameter) [s]: Sine amplitude corresponding to frequency X - free parameterWXCOS_000X
(prefixParameter) [s]: Cosine amplitude corresponding to frequency X - free parametertests/test_wavex.py
Examples:
One component:
WXFREQ_0001
= 0.01 days^-1Two component:
WXFREQ_0001
= 0.01 days^-1 ;WXFREQ_0002
= 0.1 days^-1Three component:
WXFREQ_0001
= 0.01 days^-1 ;WXFREQ_0002
= 0.2 days^-1 ;WXFREQ_0003
= 0.5 days^-1Prefit model WaveX component :
WaveX(
MJDParameter( WXEPOCH 55321.0000000000000000 (d) frozen=True),
floatParameter( WXFREQ_0001 0.1 (1 / d) frozen=True),
floatParameter( WXSIN_0001 0.001 (s) +/- 0.0 s frozen=False),
floatParameter( WXCOS_0001 0.0 (s) +/- 0.0 s frozen=False))
Postfit model results for WaveX component:
WaveX(
MJDParameter( WXEPOCH 55321.0000000000000000 (d) frozen=True),
floatParameter( WXFREQ_0001 0.1 (1 / d) frozen=True),
floatParameter( WXSIN_0001 0.001000038898416328 (s) +/- 4.481880899175662e-08 s frozen=False),
floatParameter( WXCOS_0001 -3.283614132428176e-08 (s) +/- 4.4763897206286186e-08 s frozen=False))
TO DO: conversion from Wave to WaveX