Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Fix bug with TestClassAttribute type comparison which wasn't using the intend type name.
  • Rename various variables for clarity sake.
  • Minor code style changes.
  • Update launch settings to use VS2022 VS Test console.

Motivation and Context

  • Fix issue with tests not being discovered.

How Has This Been Tested?

  • Using Test app POC. Requires another pass to run it from NuGet after it's published before validating that's a definitive fix.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Fix bug with TestClassAttribute type comparison which wasn't using the intend type name.
- Rename various variables for clarity sake.
- Minor code style changes.
- Update launch settings to use VS2022 VS Test console.
@josesimoes josesimoes force-pushed the rework-test-discovery branch from 64eeb11 to 9026cfd Compare October 29, 2022 08:05
@josesimoes josesimoes merged commit f5c1e89 into nanoframework:main Oct 29, 2022
@josesimoes josesimoes deleted the rework-test-discovery branch October 29, 2022 08:12
@josesimoes josesimoes mentioned this pull request Oct 29, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants