Skip to content

Include dashes in build meadata, e.g. 0.1.0+SNAPSHOT-123.git456 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binwiederhier opened this issue Apr 18, 2014 · 1 comment
Open

Comments

@binwiederhier
Copy link

Hi, thanks for the library. In bullet point 10, semver 2.0.0 states about build metadata: "Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]."

You library currently complains that "0.1.0+SNAPSHOT-123.git456" is not a valid version. I tried fixing the regex in Regex.php to private static $version = '/^(?<version>[0-9]+\.[0-9]+\.[0-9]+)(?<prerelease>-[0-9a-zA-Z.]+)?(?<build>\+[-0-9a-zA-Z.]+)?$/';, but that lead to another issue.

@naneau
Copy link
Owner

naneau commented Jun 17, 2014

This is a change from SemVer version 1.0.0. I am going to introduce a new branch that is fully 2.0.0 compatible.

In fact, what I'll do is change master to 2.0.0 compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants