support for FirstoreDataConverter

[goleary]

I'm curious if you have thought about adding support for withConverter by allowing users of this libary to provide their own type converters?

It might enable usage such as this:

const postConverter = {
  toFirestore(post: Post): firebase.firestore.DocumentData {
    return {title: post.title, author: post.author};
  },
  fromFirestore(
    snapshot: firebase.firestore.QueryDocumentSnapshot,
    options: firebase.firestore.SnapshotOptions
  ): Post {
    const data = snapshot.data(options)!;
    if(data.title == null || data.author == null) {
      throw new Error('Data from firestore malformed');
    }
    return new Post(data.title, data.author);
  }
};
...
const {error, data}= useCollection('posts', {converter: postConverter});

where data ends up being Post[] and add only accepts objects of type Post (that are then run through the converter)

https://firebase.google.com/docs/reference/js/firebase.firestore.FirestoreDataConverter

[nandorojo]

Interesting. Sure, I'm open to adding this. The closest thing so far is theparseDates field.

[abdel-h]

Yes it will be very interesting, for example encoding / decoding a geo point

[goleary]

FYI I've started playing around with this here.

It seems to fit into the library quite well at least for useCollection.

There's more work to be done but I'm happy to submit a PR once I get to spend a bit more time with it and get it to a good place.

[nandorojo]

@goleary Thanks, looks good. I added some notes, once those are fixed it should be good to PR.

[cheunjm]

@goleary @nandorojo any updates on this PR? if not, I am happy to work on this feature

[nandorojo]

You're welcome to!