Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround(validate): panic when trying to use inexistent .Error() #95

Merged
merged 1 commit into from
May 23, 2023
Merged

workaround(validate): panic when trying to use inexistent .Error() #95

merged 1 commit into from
May 23, 2023

Conversation

carnei-ro
Copy link
Contributor

workaround for #77

This doesn't fix the problem. Even when validate is successful, it enters into the err != nil... changing the exit code to 255.

ragazzid
ragazzid approved these changes May 22, 2023
View reviewed changes
Copy link

@ragazzid ragazzid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carnei-ro
Copy link
Contributor Author

carnei-ro commented May 22, 2023 •
edited
Loading

LGMT - but why 255?

Hey @ragazzid, I'm open to suggestions. Which error code do you think would be better? I don't want to use 1 because it is the error code when any other thing goes wrong, such as: the yaml parse fails.

@carnei-ro carnei-ro requested a review from nnarh May 23, 2023 12:49
nnarh
nnarh approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@nnarh nnarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@carnei-ro carnei-ro merged commit 4413245 into master May 23, 2023
@carnei-ro carnei-ro deleted the workaround/validate/panic-error branch May 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnarh nnarh nnarh approved these changes

@ragazzid ragazzid ragazzid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carnei-ro @ragazzid @nnarh