-
-
Notifications
You must be signed in to change notification settings - Fork 15
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: najamelan/ws_stream_wasm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.7.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: najamelan/ws_stream_wasm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.7.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 11 files changed
- 3 contributors
Commits on Oct 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 70f2528 - Browse repository at this point
Copy the full SHA 70f2528View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7353294 - Browse repository at this point
Copy the full SHA 7353294View commit details -
Configuration menu - View commit details
-
Copy full SHA for abc475d - Browse repository at this point
Copy the full SHA abc475dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 029a0cd - Browse repository at this point
Copy the full SHA 029a0cdView commit details
Commits on Jan 13, 2023
-
Fix a bug where the
onerror
callback could try to be called when it…… had already been destroyed. If there was an error establishing a WebSocket connection at an `await` point and after the point at which the `onerror` etc callbacks had been set but before the `WsStream` had been constructed then the `onerror` callback would try to be called but it would have already been destroyed because of the future being cancelled. This could happen if, for example, the initial attempt to connect to a WebSocket server timed out and we never observed an event at this `await` point: ```rust let mut evts = pharos.observe( Self::OPEN_CLOSE.into() ).await ``` To fix this we introduce a guard that is only active across the `await` points in the `WsMeta::connect` function. It is temporarily responsible for unregistering the callbacks in the case that the future is cancelled before the `WsStream` is constructed. The error that you'd otherwise run into would present itself like this in the logs: ``` ERROR: Error: closure invoked recursively or destroyed already at imports.wbg.__wbindgen_throw (http://localhost:61367/package/web/ditto.es6.js:1:70261) at wasm_bindgen::throw_str::hf6afd94675c6db0f (http://localhost:61367/package/web/ditto.wasm:wasm-function[119306]:0x3327743) at <dyn core::ops::function::FnMut<()>+Output = R as wasm_bindgen::closure::WasmClosure>::describe::invoke::h2944e7516b507b14 (http://localhost:61367/package/web/ditto.wasm:wasm-function[49343]:0x2c601d8) at __wbg_adapter_36 (http://localhost:61367/package/web/ditto.es6.js:1:12851) at WebSocket.real (http://localhost:61367/package/web/ditto.es6.js:1:11649) ``` Co-Authored-By: Daniel Henry-Mantilla <daniel.henry.mantilla@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee876f8 - Browse repository at this point
Copy the full SHA ee876f8View commit details
Commits on Jan 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fae6529 - Browse repository at this point
Copy the full SHA fae6529View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ea8699 - Browse repository at this point
Copy the full SHA 0ea8699View commit details -
Merge pull request #9 from hamchapman/hc/closure-drop-on-future-cance…
…l-fix Fix a bug where the `onerror` callback could try to be called when it had already been destroyed
Configuration menu - View commit details
-
Copy full SHA for 327ae0a - Browse repository at this point
Copy the full SHA 327ae0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 343c22a - Browse repository at this point
Copy the full SHA 343c22aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4035d46 - Browse repository at this point
Copy the full SHA 4035d46View commit details -
Merge branch 'dev' into release for 0.7.4
* dev: Changelog and version number. Update github actions. Clippy warnings. On future drop while connecting, close ws and log warning. Fix a bug where the `onerror` callback could try to be called when it had already been destroyed. Use cargo deny github action. Update send_wrapper. Add liberapay tag. Update tokio-util.
Configuration menu - View commit details
-
Copy full SHA for f68f4d5 - Browse repository at this point
Copy the full SHA f68f4d5View commit details
There are no files selected for viewing
This file was deleted.