Correct expression to deny compacted topics with local retention

Co-authored-by: @x10an14-nav <[email protected]>

Author: mortenlj

charts/kafkarator/templates/clusterpolicy.yaml

@@ -62,8 +62,9 @@ spec:
         cel:
           expressions:
             - expression: >-
-                object.spec.config.cleanupPolicy == 'compact' && (
-                    object.spec.config.localRetentionBytes > 0 ||
-                    object.spec.config.localRetentionHours > 0
-                )
+                (!has(object.spec.config.cleanupPolicy) || object.spec.config.cleanupPolicy == 'delete') ||
+                  (
+                    (!has(object.spec.config.localRetentionBytes) || object.spec.config.localRetentionBytes < 0) &&
+                    (!has(object.spec.config.localRetentionHours) || object.spec.config.localRetentionHours < 0)
+                  )
 {{- end }}

examples/topic.yaml

@@ -5,17 +5,19 @@ metadata:
   annotations:
     kafka.nais.io/removeDataWhenResourceIsDeleted: "true"
   name: mytopic
-  namespace: default
+  namespace: basseng
   labels:
-    team: default
+    team: basseng
 spec:
-  pool: some-pool
+  pool: dev-nais-dev
   config:
+    cleanupPolicy: delete
     retentionHours: 900
+    localRetentionHours: 100
   acl:
     - access: read
-      team: default
+      team: basseng
       application: myapplication
     - access: write
-      team: default
+      team: basseng
       application: otherapplication