Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/corbett bytestostring :: Python3 Support #56

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Bugfix/corbett bytestostring :: Python3 Support #56

wants to merge 14 commits into from

Conversation

asciifaceman
Copy link
Contributor

@asciifaceman asciifaceman commented Feb 5, 2021 •
edited
Loading

Sorry for the commit spam - squash on merge to clean that up.

  • Python3 support

Tested on 3.8.5

Python3 introduces more aggression around the difference between str and bytes, apparent in a few operations degoss.py was performing

  • Update binary download to just use shutil - it is chunking and buffering in the background anyways and response is a file-like object (response.read() becomes bytes in py3 and it was having encoding issues)
  • Update subprocess to use utf8 encoding (IO becomes bytes in py3)

---- Should fix #47

@asciifaceman asciifaceman changed the title Bugfix/corbett bytestostring Bugfix/corbett bytestostring :: Python3 Support Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3
1 participant
@asciifaceman