refactor: fix build warnings

Author: nadirbad

src/Api/Api.csproj

@@ -13,6 +13,12 @@
         <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>  
     </PropertyGroup>
 
+    <!-- Workaround for https://github.com/dotnet/roslyn/issues/41640 -->
+    <PropertyGroup>
+      <GenerateDocumentationFile>true</GenerateDocumentationFile>
+      <NoWarn>$(NoWarn);CS1591;CS1573</NoWarn>
+    </PropertyGroup>
+
     <ItemGroup>
         <PackageReference Include="FluentValidation.AspNetCore" Version="11.2.2" />
         <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="7.0.4">

src/Api/Program.cs

@@ -55,4 +55,6 @@
 app.UseAuthorization();
 app.MapControllers();
 
-app.Run();
+app.Run();
+
+public partial class Program { }

src/Application/Application.csproj

@@ -12,6 +12,12 @@
     <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
   </PropertyGroup>
 
+  <!-- Workaround for https://github.com/dotnet/roslyn/issues/41640 -->
+  <PropertyGroup>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <NoWarn>$(NoWarn);CS1591;CS1573</NoWarn>
+  </PropertyGroup>
+
   <ItemGroup>
     <FrameworkReference Include="Microsoft.AspNetCore.App" />
   </ItemGroup>

src/Application/Common/AuditableEntity.cs

@@ -9,4 +9,4 @@ public abstract class AuditableEntity
     public DateTime? LastModified { get; set; }
 
     public string? LastModifiedBy { get; set; }
-}
+}

src/Application/Common/Behaviours/PerformanceBehaviour.cs

@@ -45,4 +45,4 @@ public async Task<TResponse> Handle(TRequest request, RequestHandlerDelegate<TRe
 
         return response;
     }
-}
+}

src/Application/Common/Behaviours/UnhandledExceptionBehaviour.cs

@@ -28,4 +28,4 @@ public async Task<TResponse> Handle(TRequest request, RequestHandlerDelegate<TRe
             throw;
         }
     }
-}
+}

src/Application/Common/Behaviours/ValidationBehaviour.cs

@@ -32,4 +32,4 @@ public async Task<TResponse> Handle(TRequest request, RequestHandlerDelegate<TRe
         }
         return await next();
     }
-}
+}

src/Application/Common/DomainEvent.cs

@@ -13,4 +13,4 @@ protected DomainEvent()
     }
     public bool IsPublished { get; set; }
     public DateTimeOffset DateOccurred { get; protected set; } = DateTime.UtcNow;
-}
+}

src/Application/Common/Exceptions/ForbiddenAccessException.cs

@@ -17,4 +17,4 @@ public ForbiddenAccessException(string? message, Exception? innerException) : ba
     protected ForbiddenAccessException(SerializationInfo info, StreamingContext context) : base(info, context)
     {
     }
-}
+}

src/Application/Common/Exceptions/NotFoundException.cs

@@ -21,4 +21,4 @@ public NotFoundException(string name, object key)
         : base($"Entity '{name}' ({key}) was not found.")
     {
     }
-}
+}

src/Application/Common/Exceptions/UnsupportedColourException.cs

@@ -20,4 +20,4 @@ public UnsupportedColourException(string? message, Exception? innerException) :
     protected UnsupportedColourException(SerializationInfo info, StreamingContext context) : base(info, context)
     {
     }
-}
+}

src/Application/Common/Exceptions/ValidationException.cs

@@ -19,4 +19,4 @@ public ValidationException(IEnumerable<ValidationFailure> failures)
     }
 
     public IDictionary<string, string[]> Errors { get; }
-}
+}

src/Application/Common/Interfaces/ICsvFileBuilder.cs

@@ -5,4 +5,4 @@ namespace VerticalSliceArchitecture.Application.Common.Interfaces;
 public interface ICsvFileBuilder
 {
     byte[] BuildTodoItemsFile(IEnumerable<TodoItemRecord> records);
-}
+}

src/Application/Common/Interfaces/ICurrentUserService.cs

@@ -3,4 +3,4 @@
 public interface ICurrentUserService
 {
     string? UserId { get; }
-}
+}

src/Application/Common/Interfaces/IDateTime.cs

@@ -3,4 +3,4 @@
 public interface IDateTime
 {
     DateTime Now { get; }
-}
+}

src/Application/Common/Interfaces/IDomainEventService.cs

@@ -3,4 +3,4 @@
 public interface IDomainEventService
 {
     Task Publish(DomainEvent domainEvent);
-}
+}

src/Application/Common/Mappings/IMapFrom.cs

@@ -8,4 +8,4 @@ void Mapping(Profile profile)
     {
         profile.CreateMap(typeof(T), GetType());
     }
-}
+}

src/Application/Common/Mappings/MappingExtensions.cs

@@ -18,4 +18,4 @@ public static Task<List<TDestination>> ProjectToListAsync<TDestination>(this IQu
     {
         return queryable.ProjectTo<TDestination>(configuration).ToListAsync();
     }
-}
+}

src/Application/Common/Mappings/MappingProfile.cs

@@ -29,4 +29,4 @@ private void ApplyMappingsFromAssembly(Assembly assembly)
 
         }
     }
-}
+}

src/Application/Common/Models/DomainEventNotification.cs

@@ -10,4 +10,4 @@ public DomainEventNotification(TDomainEvent domainEvent)
     }
 
     public TDomainEvent DomainEvent { get; }
-}
+}

src/Application/Common/Models/PaginatedList.cs

@@ -28,4 +28,4 @@ public static async Task<PaginatedList<T>> CreateAsync(IQueryable<T> source, int
 
         return new PaginatedList<T>(items, count, pageNumber, pageSize);
     }
-}
+}

src/Application/Common/Models/Result.cs

@@ -21,4 +21,4 @@ public static Result Failure(IEnumerable<string> errors)
     {
         return new Result(false, errors);
     }
-}
+}

src/Application/Common/Security/AuthorizeAttribute.cs

@@ -20,4 +20,4 @@ public AuthorizeAttribute() { }
     /// Gets or sets the policy name that determines access to the resource.
     /// </summary>
     public string Policy { get; set; } = string.Empty;
-}
+}

src/Application/Common/ValueObject.cs

@@ -39,4 +39,4 @@ public override int GetHashCode()
             .Select(x => x != null ? x.GetHashCode() : 0)
             .Aggregate((x, y) => x ^ y);
     }
-}
+}

src/Application/ConfigureServices.cs

@@ -55,4 +55,4 @@ public static IServiceCollection AddInfrastructure(this IServiceCollection servi
 
         return services;
     }
-}
+}

src/Application/Domain/Todos/TodoItem.cs

@@ -60,4 +60,4 @@ public class TodoItemRecord : IMapFrom<TodoItem>
     public string? Title { get; set; }
 
     public bool Done { get; set; }
-}
+}

src/Application/Domain/Todos/TodoList.cs

@@ -12,4 +12,4 @@ public class TodoList : AuditableEntity
     public Colour Colour { get; set; } = Colour.White;
 
     public IList<TodoItem> Items { get; private set; } = new List<TodoItem>();
-}
+}

src/Application/Domain/ValueObjects/Colour.cs

@@ -77,4 +77,4 @@ protected override IEnumerable<object> GetEqualityComponents()
     {
         yield return Code;
     }
-}
+}

src/Application/Features/TodoItems/DeleteTodoItem.cs

@@ -37,13 +37,7 @@ public DeleteTodoItemCommandHandler(ApplicationDbContext context)
     public async Task<Unit> Handle(DeleteTodoItemCommand request, CancellationToken cancellationToken)
     {
         var entity = await _context.TodoItems
-            .FindAsync(new object[] { request.Id }, cancellationToken);
-
-        if (entity == null)
-        {
-            throw new NotFoundException(nameof(TodoItem), request.Id);
-        }
-
+            .FindAsync(new object[] { request.Id }, cancellationToken) ?? throw new NotFoundException(nameof(TodoItem), request.Id);
         _context.TodoItems.Remove(entity);
 
         entity.DomainEvents.Add(new TodoItemDeletedEvent(entity));

src/Application/Features/TodoItems/EventHandlers/TodoItemCompletedEventHandler.cs

@@ -24,4 +24,4 @@ public Task Handle(DomainEventNotification<TodoItemCompletedEvent> notification,
 
         return Task.CompletedTask;
     }
-}
+}

src/Application/Features/TodoItems/EventHandlers/TodoItemCreatedEventHandler.cs

@@ -23,4 +23,4 @@ public Task Handle(DomainEventNotification<TodoItemCreatedEvent> notification, C
 
         return Task.CompletedTask;
     }
-}
+}

src/Application/Features/TodoItems/GetTodoItemsWithPagination.cs

@@ -76,4 +76,4 @@ public class TodoItemBriefDto : IMapFrom<TodoItem>
     public string? Title { get; set; }
 
     public bool Done { get; set; }
-}
+}

src/Application/Features/TodoItems/UpdateTodoItem.cs

@@ -58,12 +58,7 @@ public UpdateTodoItemCommandHandler(ApplicationDbContext context)
     public async Task<Unit> Handle(UpdateTodoItemCommand request, CancellationToken cancellationToken)
     {
         var entity = await _context.TodoItems
-            .FindAsync(new object[] { request.Id }, cancellationToken);
-
-        if (entity == null)
-        {
-            throw new NotFoundException(nameof(TodoItem), request.Id);
-        }
+            .FindAsync(new object[] { request.Id }, cancellationToken) ?? throw new NotFoundException(nameof(TodoItem), request.Id);
 
         entity.Title = request.Title;
         entity.Done = request.Done;

src/Application/Features/TodoItems/UpdateTodoItemDetail.cs

@@ -48,12 +48,7 @@ public UpdateTodoItemDetailCommandHandler(ApplicationDbContext context)
     public async Task<Unit> Handle(UpdateTodoItemDetailCommand request, CancellationToken cancellationToken)
     {
         var entity = await _context.TodoItems
-            .FindAsync(new object[] { request.Id }, cancellationToken);
-
-        if (entity == null)
-        {
-            throw new NotFoundException(nameof(TodoItem), request.Id);
-        }
+            .FindAsync(new object[] { request.Id }, cancellationToken) ?? throw new NotFoundException(nameof(TodoItem), request.Id);
 
         entity.ListId = request.ListId;
         entity.Priority = request.Priority;

src/Application/Features/TodoLists/CreateTodoList.cs

@@ -65,4 +65,4 @@ public async Task<int> Handle(CreateTodoListCommand request, CancellationToken c
 
         return entity.Id;
     }
-}
+}

src/Application/Features/TodoLists/DeleteTodoList.cs

@@ -39,17 +39,12 @@ public async Task<Unit> Handle(DeleteTodoListCommand request, CancellationToken
     {
         var entity = await _context.TodoLists
             .Where(l => l.Id == request.Id)
-            .SingleOrDefaultAsync(cancellationToken);
-
-        if (entity == null)
-        {
-            throw new NotFoundException(nameof(TodoList), request.Id);
-        }
+            .SingleOrDefaultAsync(cancellationToken) ?? throw new NotFoundException(nameof(TodoList), request.Id);
 
         _context.TodoLists.Remove(entity);
 
         await _context.SaveChangesAsync(cancellationToken);
 
         return Unit.Value;
     }
-}
+}

src/Application/Features/TodoLists/ExportTodos.cs

@@ -72,4 +72,4 @@ public async Task<ExportTodosVm> Handle(ExportTodosQuery request, CancellationTo
 
         return vm;
     }
-}
+}

src/Application/Features/TodoLists/GetTodos.cs

@@ -104,4 +104,4 @@ public async Task<TodosVm> Handle(GetTodosQuery request, CancellationToken cance
                 .ToListAsync(cancellationToken)
         };
     }
-}
+}

src/Application/Features/TodoLists/UpdateTodoList.cs

@@ -70,17 +70,12 @@ public async Task<Unit> Handle(UpdateTodoListCommand request, CancellationToken
     {
         var entity = await _context.TodoLists
             .FindAsync(new object[] { request.Id }, cancellationToken)
-            .ConfigureAwait(false);
-
-        if (entity == null)
-        {
-            throw new NotFoundException(nameof(TodoList), request.Id);
-        }
+            .ConfigureAwait(false) ?? throw new NotFoundException(nameof(TodoList), request.Id);
 
         entity.Title = request.Title;
 
         await _context.SaveChangesAsync(cancellationToken);
 
         return Unit.Value;
     }
-}
+}

src/Application/Infrastructure/Files/CsvFileBuilder.cs

@@ -23,4 +23,4 @@ public byte[] BuildTodoItemsFile(IEnumerable<TodoItemRecord> records)
 
         return memoryStream.ToArray();
     }
-}
+}

src/Application/Infrastructure/Files/Maps/TodoItemRecordMap.cs

@@ -14,4 +14,4 @@ public TodoItemRecordMap()
 
         Map(m => m.Done).ConvertUsing(c => c.Done ? "Yes" : "No");
     }
-}
+}

src/Application/Infrastructure/Persistence/ApplicationDbContext.cs

@@ -83,4 +83,4 @@ private async Task DispatchEvents(DomainEvent[] events)
             await _domainEventService.Publish(@event);
         }
     }
-}
+}

src/Application/Infrastructure/Persistence/ApplicationDbContextSeed.cs

@@ -30,4 +30,4 @@ public static async Task SeedSampleDataAsync(ApplicationDbContext context)
             await context.SaveChangesAsync();
         }
     }
-}
+}

src/Application/Infrastructure/Persistence/Configurations/TodoItemConfiguration.cs

@@ -15,4 +15,4 @@ public void Configure(EntityTypeBuilder<TodoItem> builder)
             .HasMaxLength(200)
             .IsRequired();
     }
-}
+}

src/Application/Infrastructure/Persistence/Configurations/TodoListConfiguration.cs

@@ -16,4 +16,4 @@ public void Configure(EntityTypeBuilder<TodoList> builder)
         builder
             .OwnsOne(b => b.Colour);
     }
-}
+}

src/Application/Infrastructure/Persistence/Migrations/20220322201554_InitialMigration.cs

@@ -66,4 +66,4 @@ protected override void Down(MigrationBuilder migrationBuilder)
                 name: "TodoLists");
         }
     }
-}
+}

src/Application/Infrastructure/Services/DateTimeService.cs

@@ -5,4 +5,4 @@ namespace VerticalSliceArchitecture.Application.Infrastructure.Services;
 public class DateTimeService : IDateTime
 {
     public DateTime Now => DateTime.Now;
-}
+}