fix subscribe (#528)

Author: binbin0325

Diff for: clients/naming_client/naming_client.go

@@ -93,7 +93,7 @@ func NewNamingClient(nc nacos_client.INacosClient) (NamingClient, error) {
 	return naming, nil
 }
 
-//RegisterInstance register instance
+// RegisterInstance register instance
 func (sc *NamingClient) RegisterInstance(param vo.RegisterInstanceParam) (bool, error) {
 	if param.ServiceName == "" {
 		return false, errors.New("serviceName cannot be empty!")
@@ -135,7 +135,7 @@ func (sc *NamingClient) RegisterInstance(param vo.RegisterInstanceParam) (bool,
 
 }
 
-//DeregisterInstance deregister instance
+// DeregisterInstance deregister instance
 func (sc *NamingClient) DeregisterInstance(param vo.DeregisterInstanceParam) (bool, error) {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -149,7 +149,7 @@ func (sc *NamingClient) DeregisterInstance(param vo.DeregisterInstanceParam) (bo
 	return true, nil
 }
 
-//UpdateInstance update information for exist instance.
+// UpdateInstance update information for exist instance.
 func (sc *NamingClient) UpdateInstance(param vo.UpdateInstanceParam) (bool, error) {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -183,7 +183,7 @@ func (sc *NamingClient) UpdateInstance(param vo.UpdateInstanceParam) (bool, erro
 	return true, nil
 }
 
-//GetService get service info
+// GetService get service info
 func (sc *NamingClient) GetService(param vo.GetServiceParam) (model.Service, error) {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -192,7 +192,7 @@ func (sc *NamingClient) GetService(param vo.GetServiceParam) (model.Service, err
 	return service, err
 }
 
-//GetAllServicesInfo get all services info
+// GetAllServicesInfo get all services info
 func (sc *NamingClient) GetAllServicesInfo(param vo.GetAllServiceInfoParam) (model.ServiceList, error) {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -214,7 +214,7 @@ func (sc *NamingClient) GetAllServicesInfo(param vo.GetAllServiceInfoParam) (mod
 	return services, nil
 }
 
-//SelectAllInstances select all instances
+// SelectAllInstances select all instances
 func (sc *NamingClient) SelectAllInstances(param vo.SelectAllInstancesParam) ([]model.Instance, error) {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -226,7 +226,7 @@ func (sc *NamingClient) SelectAllInstances(param vo.SelectAllInstancesParam) ([]
 	return service.Hosts, err
 }
 
-//SelectInstances select instances
+// SelectInstances select instances
 func (sc *NamingClient) SelectInstances(param vo.SelectInstancesParam) ([]model.Instance, error) {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -252,7 +252,7 @@ func (sc *NamingClient) selectInstances(service model.Service, healthy bool) ([]
 	return result, nil
 }
 
-//SelectOneHealthyInstance select one healthy instance
+// SelectOneHealthyInstance select one healthy instance
 func (sc *NamingClient) SelectOneHealthyInstance(param vo.SelectOneHealthInstanceParam) (*model.Instance, error) {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -284,28 +284,27 @@ func (sc *NamingClient) selectOneHealthyInstances(service model.Service) (*model
 		return nil, errors.New("healthy instance list is empty!")
 	}
 
-	chooser := newChooser(result)
-	instance := chooser.pick()
+	instance := newChooser(result).pick()
 	return &instance, nil
 }
 
-type instance []model.Instance
+type instances []model.Instance
 
-func (a instance) Len() int {
+func (a instances) Len() int {
 	return len(a)
 }
 
-func (a instance) Swap(i, j int) {
+func (a instances) Swap(i, j int) {
 	a[i], a[j] = a[j], a[i]
 }
 
-func (a instance) Less(i, j int) bool {
+func (a instances) Less(i, j int) bool {
 	return a[i].Weight < a[j].Weight
 }
 
 // NewChooser initializes a new Chooser for picking from the provided Choices.
-func newChooser(instances []model.Instance) Chooser {
-	sort.Sort(instance(instances))
+func newChooser(instances instances) Chooser {
+	sort.Sort(instances)
 	totals := make([]int, len(instances))
 	runningTotal := 0
 	for i, c := range instances {
@@ -321,7 +320,7 @@ func (chs Chooser) pick() model.Instance {
 	return chs.data[i]
 }
 
-//Subscribe subscibe service
+// Subscribe subscribe service
 func (sc *NamingClient) Subscribe(param *vo.SubscribeParam) error {
 	if len(param.GroupName) == 0 {
 		param.GroupName = constant.DEFAULT_GROUP
@@ -337,13 +336,13 @@ func (sc *NamingClient) Subscribe(param *vo.SubscribeParam) error {
 	if err != nil {
 		return err
 	}
-	if !sc.hostReactor.serviceProxy.clientConfig.NotLoadCacheAtStart {
+	if sc.hostReactor.serviceProxy.clientConfig.NotLoadCacheAtStart {
 		sc.subCallback.ServiceChanged(&svc)
 	}
 	return nil
 }
 
-//Unsubscribe unsubscribe service
+// Unsubscribe unsubscribe service
 func (sc *NamingClient) Unsubscribe(param *vo.SubscribeParam) error {
 	sc.subCallback.RemoveCallbackFuncs(util.GetGroupName(param.ServiceName, param.GroupName), strings.Join(param.Clusters, ","), &param.SubscribeCallback)
 	return nil