Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init nodes folder when created so NPM install doesn't fail #3934

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Init nodes folder when created so NPM install doesn't fail #3934

merged 1 commit into from
Aug 24, 2022

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Aug 24, 2022

No description provided.

ivov
ivov approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. Cannot reproduce the issue on master but tested with npm 6, 7 and 8 and all working.

@ivov ivov merged commit 2d6eea8 into master Aug 24, 2022
@ivov ivov deleted the n8n-4356-fix-issue-with-non-init-nodes-folder branch August 24, 2022 09:58
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
@janober
Copy link
Member

janober commented Aug 24, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krynble @janober @ivov