fix(cli): tsc build errors should fail turborepo builds as well #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Confirmed working, Turborepo build halts on tsc build fail for cli package.
n8n:build: cache miss, executing c4eed8e4537c69c9
n8n:build:
n8n:build: > [email protected] build
n8n:build: > node scripts/build.mjs
n8n:build:
n8n:build: Typescript Compilation failed:
n8n:build: src/ActiveExecutions.ts(73,34): error TS2589: Type instantiation is excessively deep and possibly infinite.
n8n:build:
n8n:build: npm ERR! Lifecycle script `build` failed with error:
n8n:build: npm ERR! Error: command failed
n8n:build: npm ERR! in workspace: [email protected]
n8n:build: npm ERR! at location: /Users/ivov/Desktop/n8n2/packages/cli
n8n:build: ERROR: command finished with error: command (packages/cli) npm run build exited (1)
command (packages/cli) npm run build exited (1)
In future it should halt for tsc build errors in any package.
we already do that. |
janober
added
Upcoming Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.