Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create multiple tasks at once with Todoist #3613

Closed
danoc opened this issue Jun 29, 2022 · 3 comments · Fixed by #3614
Closed

Can't create multiple tasks at once with Todoist #3613

danoc opened this issue Jun 29, 2022 · 3 comments · Fixed by #3614

Comments

@danoc
Copy link

danoc commented Jun 29, 2022

Describe the bug
Hello! There's an issue in the Todoist integration that causes it to create multiple copies of the same task when it receives multiple items.

I believe the problem is related to a recent refactor. Notice how CreateHandler's handleOperation function expects an itemNumber (first link) and that the itemNumber is hardcoded as 0 (second link):

https://github.com/n8n-io/n8n/pull/3074/files#diff-7569657bb643f975e22272d9c9b11a255a0ce409845a59a2e0605f55c5b59354R10-R12

https://github.com/n8n-io/n8n/pull/3074/files#diff-10b0852fb2ddcadcdfd9bc00e6718fa0e8eea340f32fba38cf8e0a404551e1adR18-R20

To Reproduce
Steps to reproduce the behavior:

  1. Pass in a list of X items to the Todoist Task Create operation.
  2. Notice that X items get created, but they all share the same title despite using an expression.
  3. Switch Todoist for another integration like "Send Email" and notice that it works as expected and each email has unique content.

Expected behavior
X number of items get created with unique details

Environment (please complete the following information):

  • OS: Official Docker image
  • n8n Version: 0.183.0
  • Node.js Version Unknown
  • Database system: SQLite
  • Operation mode: own

Additional context
N/A

@danoc
Copy link
Author

danoc commented Jun 29, 2022

cc: @agobrech and @RicardoE105 who recently worked on the integration: #3074

@Joffcom
Copy link
Member

Joffcom commented Jun 29, 2022

Hey @danoc,

Good spot, I have just popped in a PR to fix this.

@Joffcom Joffcom linked a pull request Jun 29, 2022 that will close this issue
@janober
Copy link
Member

janober commented Jul 4, 2022

Thanks a lot. Fix got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants