-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Using pageCategory
prop to assemble the list of settings routes inβ¦
#3562
Merged
krynble
merged 1 commit into
node-sideload-npm-install
from
settings-permission-logic-update
Jun 20, 2022
Merged
π Using pageCategory
prop to assemble the list of settings routes inβ¦
#3562
krynble
merged 1 commit into
node-sideload-npm-install
from
settings-permission-logic-update
Jun 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦stead of hard-coded array
krynble
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 21, 2022
β¦stead of hard-coded array (#3562)
janober
added a commit
that referenced
this pull request
Jul 20, 2022
* β¨ Make it possible to dynamically load node packages * β‘ Fix comment * β¨ Make possible to dynamically install nodes from npm * Created migration for sqlite regarding community nodes * Saving to db whenever a package with nodes is installed * Created endpoint to fetch installed packages * WIP - uninstall package with nodes * Fix lint issues * Updating nodes via API * Lint and improvement fixes * Created community node helpers and removed packages taht do not contain nodes * Check for package updates when fetching installed packages * Blocked access to non-owner and preventing incorrect install of packages * Added auto healing process * Unit tests for helpers * Finishing tests for helpers * Improved unit tests, refactored more helpers and created integration tests for GET * Implemented detection of missing packages on init and added warning to frontend settings * Add check for banned packages and fix broken tests * Create migrations for other db systems * Updated with latest changes from master * Fixed conflict errors * Improved unit tests, refactored more helpers and created integration tests for GET * Implemented detection of missing packages on init and added warning to frontend settings * π₯ Removing access check for the Settings sidebar item * β¨ Added inital community nodes settings screen * β‘Added executionMode flag to settings * β¨ Implemented N8N-callout component * πUpdating Callout component template propery names * π Updating Callout component styling. * πUpdating Callout component sizing and colors. * βοΈ Updating Callout component test snapshots after styling changes * β¨ Updating the `ActionBox` component so it supports callouts and conditional button rendering * π Removing duplicate callout theme validation in the `ActionBox` component. Adding a selection control for it in the storybook. * β¨ Added warning message if instance is in the queue mode. Updated colors based on the new design. * β‘ Added a custom permission support to router * π¨ Implemented UM detection as a custom permission. * πUpdating route permission logic. * β¨ Implemented installed community packages list in the settings view * π Updating settings routes rules and community nodes setting view. * Allow installation of packages that failed to load * π Updating `ActionBox`, `CommuntyPackageCard` components and settings loading logic. * π Fixing community nodes loading state and sidebar icon spacing. * β¨ Implemented loading skeletons for community package cards * π Handling errrors while loading installed package list. Updating spacing. * π Updating community nodes error messages. * Added disable flag * π Fixing a community nodes update detection bug when there are missing packages. (#3497) * β¨ Added front-end support for community nodes feature flag * β¨ Implemented community package installation modal dialog * π Community nodes installation modal updates: Moved links to constants and used them in translations, disabling inputs in loading state. * β¨ Implemented community packages install flow * Standardize error codes (#3501) * Standardize error: 400 for request issues such as invalid package name and 500 for installation problems * Fix http status code for when package is not found * β¨ Implemented community package installation modal dialog * π Community nodes installation modal updates: Moved links to constants and used them in translations, disabling inputs in loading state. * β¨ Implemented community packages install flow * β¨ Updated error handling based on the response codes * β¨ Implemented community package installation modal dialog * β¨ Implemented community package uninstall flow. * β¨ Finished update confirm modal UI * π Replaced community nodes tooltip image with the one exported from figma. * β¨ Implemented community package update process * β¨ Updating community nodes list after successful package update * π Updating public API setting route to use new access rules. Updating express app definition in community nodes tests * β¨ Implemented community package installation modal dialog * π Community nodes installation modal updates: Moved links to constants and used them in translations, disabling inputs in loading state. * β¨ Implemented community packages install flow * β¨ Updated error handling based on the response codes * Change output for installation request * Improve payload for update requests * π Updating community nodes install modal UI * π Updating community nodes confirm modal logic * π Refactoring community nodes confirm modal dialog * π Separating community nodes components loading states * π Updating community nodes install modal spacing. * Fix behavior for installing already installed packages * π‘ Commenting community nodes install process * π₯ Removing leftover commits of deleted Vue mutations * β¨ Updated node list to identify community nodes and handle node name clash * β¨ Implemented missing community node dialog. * π Updating n8n-tabs component to support tooltips * β¨ Updating node details with community node details. * π¨ Using back-end response when updating community packages * π Updating tabs component and refactoring community nodes store mutations * π Adding community node flag to node type descriptions and using it to identify community nodes * π Hiding unnecessary elements from missing node details panel. * π Updating missing node type descriptions for custom and community nodes * π Updating community node package name detection logic * π Removing communityNode flag from node description * β¨ Adding `force` flag to credentials fetching (#3527) * β¨ Adding `force` flag to credentials fetching which can be used to skip check when loading credentials * β¨ Forcing credentials loading when opening nodeView * π Minor updates to community nodes details panel * tests for post endpoint * duplicate comments * Add Patch and Delete enpoints tests * π Using `pageCategory`prop to assemble the list of settings routes instead of hard-coded array (#3562) * π Added front-end telemetry events for community nodes * π Updating community nodes telemetry events * π Updating community nodes settings UI elements based on product/design review * π Updating node view & node details view for community nodes based on product/design feedback * π Fixing community node text capitalisation * β¨ Adding community node install error message under the package name input field * Fixed and improved tests * Fix lint issue * feat: Migrated to npm release of riot-tmpl fork. * π Updating community nodes telemetry events based on the product review * π Updating community nodes UI based on the design feedback * π Merging recent node draggable panels changes * Implement self healing process * Improve error messages for package name requirement and disk space * π Removing front-end error message override since appropriate response is available from the back-end * Fix lint issues * Fix installed node name * π Removed additional node name parsing * π Updating community nodes telemetry events * Fix postgres migration for cascading nodes when package is removed * Remove postman mock for banned packages * π Adding missing telemetry event for community node documentation click * π Fixing community nodes UI bugs reported during the bug bash * Fix issue with uninstalling packages not reflecting UI * π Fixing a missing node type bug when trying to run a workflow. * Improve error detection for installing packages * π Updating community nodes components styling and wording based on the product feedback * Implement telemetry be events * Add author name and email to packages * Fix telemetry be events for community packages * π Updating front-end telemetry events with community nodes author data * π Updating credentials documentation link logic to handle community nodes credentials * π Fixing draggable panels logic * Fix duplicate wrong import * π Hiding community nodes credentials documentation links when they don't contain an absolute URL * Fix issue with detection of missing packages * π Adding the `Docs` tab to community nodes * π Adding a failed loading indicator to community nodes list * Prevent n8n from crashing on startup * Refactor and improve code quality * β‘ Remove not needed depenedency Co-authored-by: Omar Ajoue <[email protected]> Co-authored-by: Milorad FilipoviΔ <[email protected]> Co-authored-by: Milorad FIlipoviΔ <[email protected]> Co-authored-by: agobrech <[email protected]> Co-authored-by: Alex Grozav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krynble Please review