Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to dynamically load node packages with dependencies #2849

Merged
merged 171 commits into from
Jul 20, 2022
Merged

Make it possible to dynamically load node packages with dependencies #2849

merged 171 commits into from
Jul 20, 2022

Conversation

janober
Copy link
Member

@janober janober commented Feb 20, 2022 •
edited
Loading

First POC to make it possible to dynamically load additional credentials/nodes at runtime from npm. Building on top and partly replacing code of my previous PR #2625.

Info:

  • does not work yet with queue-mode
  • did not do proper testing yet
  • no UI implemented, only REST endpoint

Test:

curl -X POST http://localhost:5678/rest/node \
   -H "Content-Type: application/json" \
   -d '{"name": "n8n-nodes-chatwork"}'

@Joffcom Joffcom added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 23, 2022
@krynble krynble force-pushed the node-sideload-npm-install branch 3 times, most recently from eaa3155 to 3d1de4e Compare April 11, 2022 07:52
@janober janober mentioned this pull request Apr 19, 2022
Closed
@krynble krynble force-pushed the node-sideload-npm-install branch 3 times, most recently from adbdb38 to 55ebf17 Compare April 25, 2022 07:16
@krynble krynble force-pushed the node-sideload-npm-install branch from 8867489 to 1a87d09 Compare May 23, 2022 15:14
janober and others added 19 commits May 30, 2022 12:11
@janober @krynble
✨ Make it possible to dynamically load node packages
712a014
@janober @krynble
⚡ Fix comment
2c35d8a
@janober @krynble
✨ Make possible to dynamically install nodes from npm
4a5e1d3
@krynble
Created migration for sqlite regarding community nodes
402f55f
@krynble
Saving to db whenever a package with nodes is installed
8b3c0ef
@krynble
Created endpoint to fetch installed packages
371d7d9
@krynble
WIP - uninstall package with nodes
bd920c3
@krynble
Fix lint issues
4d7861b
@krynble
Updating nodes via API
83bb44b
@krynble
Lint and improvement fixes
492c503
@krynble
Created community node helpers and removed packages taht do not conta…
73d7eb9 
…in nodes
@krynble
Check for package updates when fetching installed packages
17d7aa5
@krynble
Blocked access to non-owner and preventing incorrect install of packages
66ddd9b
@krynble
Added auto healing process
2a1efbf
@krynble
Unit tests for helpers
2a3368c
@krynble
Finishing tests for helpers
46545ee
@krynble
Improved unit tests, refactored more helpers and created integration …
7723495 
…tests for GET
@krynble
Implemented detection of missing packages on init and added warning t…
ab85663 
…o frontend settings
@krynble
Add check for banned packages and fix broken tests
ae012e0
krynble and others added 23 commits June 30, 2022 11:51
@krynble
Implement telemetry be events
2f15945
@krynble
Merge branch 'node-sideload-npm-install' of github.com:n8n-io/n8n int…
b961b1a 
…o node-sideload-npm-install
@krynble
Add author name and email to packages
6ab44af
@krynble
Fix telemetry be events for community packages
4a40040
@MiloradFilipovic
📈 Updating front-end telemetry events with community nodes author data
bbd9bf7
@krynble
Merge master
92816ca
@MiloradFilipovic
💄 Updating credentials documentation link logic to handle community n…
cbcc1a1 
…odes credentials
@krynble
Merge branch 'master' into node-sideload-npm-install
282a415
@MiloradFilipovic
🐛 Fixing draggable panels logic
cc073bc
@krynble
Fix duplicate wrong import
d50d566
@krynble
Merge branch 'node-sideload-npm-install' of github.com:n8n-io/n8n int…
35ff379 
…o node-sideload-npm-install
@MiloradFilipovic
💄 Hiding community nodes credentials documentation links when they do…
ad0e484 
…n't contain an absolute URL
@krynble
Fix issue with detection of missing packages
ec30791
@krynble
Merge branch 'node-sideload-npm-install' of github.com:n8n-io/n8n int…
49f69d8 
…o node-sideload-npm-install
@MiloradFilipovic
💄 Adding the Docs tab to community nodes
9f089a0
@MiloradFilipovic
💄 Adding a failed loading indicator to community nodes list
21782cf
@krynble
Prevent n8n from crashing on startup
74a005c
@krynble
Merge branch 'node-sideload-npm-install' of github.com:n8n-io/n8n int…
05448fd 
…o node-sideload-npm-install
@krynble
Refactor and improve code quality
1b44397
@krynble
Merge master
9c7437e
@krynble
Merge master
3b8ff29
@krynble
Merge master and fix conflicts
0093b64
@janober
⚡ Remove not needed depenedency
a4f62f4
@janober janober merged commit c85faff into master Jul 20, 2022
@janober janober deleted the node-sideload-npm-install branch July 20, 2022 14:24
@janober
Copy link
Member Author

janober commented Jul 20, 2022

Thanks a lot. Got merged!

@janober janober added the Upcoming Release Will be part of the upcoming release label Jul 20, 2022
@janober
Copy link
Member Author

janober commented Jul 20, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jul 20, 2022
@michael-dm
Copy link

so does this help using npm modules in Function nodes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@janober @michael-dm @Joffcom @krynble @MiloradFilipovic @agobrech @alexgrozav