-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Increase default concurrency and timeout in task runners #12496
Merged
ivov
merged 2 commits into
master
from
increase-default-concurrency-and-timeout-in-task-runners
Jan 8, 2025
Merged
fix(core): Increase default concurrency and timeout in task runners #12496
ivov
merged 2 commits into
master
from
increase-default-concurrency-and-timeout-in-task-runners
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n Run #8649
Run Properties:
|
Project |
n8n
|
Branch Review |
increase-default-concurrency-and-timeout-in-task-runners
|
Run status |
Passed #8649
|
Run duration | 04m 48s |
Commit |
1dfaaec8f2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
|
Committer | Iván Ovejero |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
489
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
ivov
deleted the
increase-default-concurrency-and-timeout-in-task-runners
branch
January 8, 2025 10:25
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increase default values for
N8N_RUNNERS_MAX_CONCURRENCY
andN8N_RUNNERS_TASK_TIMEOUT
to approximate historical Code node behavior. We will reduce these back to more conservative values with n8n v2.Related Linear tickets, Github issues, and Community forum posts
Context: https://n8nio.slack.com/archives/C035KBDA917/p1736150633407259
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)