-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Postgres Node): Allow passing in arrays to JSON columns for insert #12452
Merged
+185
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dana-gill
force-pushed
the
node-1705-insert-array-json
branch
from
January 3, 2025 16:38
e7498ba
to
4005bec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
Jan 3, 2025
ShireenMissi
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
n8n Run #8647
Run Properties:
|
Project |
n8n
|
Branch Review |
node-1705-insert-array-json
|
Run status |
Passed #8647
|
Run duration | 04m 53s |
Commit |
d84b1c53ba: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 dana-gill 🗃️ e2e/*
|
Committer | Dana Lee |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
489
|
View all changes introduced in this branch ↗︎ |
An array is technically JSON. Postgres allows for this and we should enable this for the insert node. We will need to get the `column` node parameters first and then call values on it since the validator in core will not accept arrays to be passed in for columns with JSON. As a result, we will use `pgp.as.json` to handle validation. This also gives us the added benefit of converting the values which are meant to be JSON into a format Postgres can understand. We also need to enable raw mode since we will use `pgp.helpers.concat` for the queries in `configureQueryRunners`.
ShireenMissi
force-pushed
the
node-1705-insert-array-json
branch
from
January 8, 2025 09:17
4005bec
to
d84b1c5
Compare
ShireenMissi
approved these changes
Jan 8, 2025
✅ All Cypress E2E specs passed |
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An array is technically JSON. Postgres allows for this and we should
enable this for the insert node.
Workflow for testing:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1705/postgres-node-cant-insert-an-array-into-json-column-in-postgres
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)