Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAI Node): Update node to account for URL in credentials #12356

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 23, 2024

Summary

Missed this one in #12175

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2887/[n8n-nodes]-move-openai-base-url-option-to-credentials

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Update OpenAI node to account for URL in credentials fix(OpenAI): Update node to account for URL in credentials Dec 23, 2024
@RicardoE105 RicardoE105 changed the title fix(OpenAI): Update node to account for URL in credentials fix(OpenAI Node): Update node to account for URL in credentials Dec 23, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-langchain/nodes/vendors/OpenAi/transport/index.ts 80.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please add a unit test here? Thank you

@RicardoE105 RicardoE105 requested a review from mutdmour December 30, 2024 20:07
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 30, 2024

n8n    Run #8516

Run Properties:  status check passed Passed #8516  •  git commit f78ccebe51: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #8516
Run duration 04m 45s
Commit git commit f78ccebe51: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 484
View all changes introduced in this branch ↗︎

@RicardoE105 RicardoE105 requested a review from mutdmour December 30, 2024 20:27
Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit f78cceb into master Dec 30, 2024
37 checks passed
@RicardoE105 RicardoE105 deleted the update-open-ai-to-account-for-url branch December 30, 2024 20:51
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants