-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OpenAI Node): Update node to account for URL in credentials #12356
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you please add a unit test here? Thank you
|
n8n Run #8516
Run Properties:
|
Project |
n8n
|
Branch Review |
master
|
Run status |
Passed #8516
|
Run duration | 04m 45s |
Commit |
f78ccebe51: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
|
Committer | Ricardo Espinoza |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
484
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Got released with |
1 similar comment
Got released with |
Got released with |
1 similar comment
Got released with |
Summary
Missed this one in #12175
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2887/[n8n-nodes]-move-openai-base-url-option-to-credentials
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)