Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Improve configurable nodes design on new canvas #12317

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Dec 19, 2024

Summary

Screenshot 2024-12-19 at 17 35 02

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-445/configurable-nodes-dont-display-the-same-as-the-old-canvas

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Dec 19, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 20, 2024

n8n    Run #8650

Run Properties:  status check passed Passed #8650  •  git commit ae8c4dbf4b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-445-configurable-nodes-dont-display-the-same-as-the-old-canvas
Run status status check passed Passed #8650
Run duration 04m 55s
Commit git commit ae8c4dbf4b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Jan 8, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

…e-nodes-dont-display-the-same-as-the-old-canvas
Copy link
Contributor

github-actions bot commented Jan 8, 2025

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 0ecce10 into master Jan 8, 2025
37 checks passed
@alexgrozav alexgrozav deleted the cat-445-configurable-nodes-dont-display-the-same-as-the-old-canvas branch January 8, 2025 11:11
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants