-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Redis Node): Add support for username auth #12274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good 😄 It looks like CodeCoverage is complaining about not being able to test this line. Could you add a utils.redisConnectionTest
test? I think checking that setupRedisClient
is called with the right credentials should suffice.
Just to note as well: I tested this a bit differently from the PR description. Here is what I did:
My previous credentials also worked without having to change anything ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of moving the tests
to a __tests__
folder? I feel like it introduces a slightly new way to structure the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__tests__
make sense :)
|
n8n Run #8413
Run Properties:
|
Project |
n8n
|
Branch Review |
NODE-2174-add-redis-user-auth
|
Run status |
Passed #8413
|
Run duration | 04m 43s |
Commit |
d069fd9320: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
|
Committer | कारतोफ्फेलस्क्रिप्ट™ |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
0
|
Skipped |
0
|
Passing |
480
|
View all changes introduced in this branch ↗︎ |
|
1 similar comment
|
✅ All Cypress E2E specs passed |
Got released with |
Summary
This PR adds support for username auth on Redis and RedisTrigger nodes.
To test this, you can use the following docker-compose snippet to start a redis container to test these nodes with:
Related Linear tickets, Github issues, and Community forum posts
NODE-2174
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)