Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix sticky color picker getting covered by nodes on new canvas #12263

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

alexgrozav
Copy link
Member

Summary

Screen.Recording.2024-12-17.at.14.47.35.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-428/sticky-color-picker-node-overlap-conflict

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Dec 17, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 17, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 17, 2024

n8n    Run #8379

Run Properties:  status check passed Passed #8379  •  git commit e31b282925: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-428-sticky-color-picker-node-overlap-conflict
Run status status check passed Passed #8379
Run duration 04m 37s
Commit git commit e31b282925: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 481
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...onents/canvas/elements/nodes/CanvasNodeToolbar.vue 81.25% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 27bd3c8 into master Dec 17, 2024
37 checks passed
@alexgrozav alexgrozav deleted the cat-428-sticky-color-picker-node-overlap-conflict branch December 17, 2024 13:48
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants