-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(editor): SchemaView performance improvement by β90% π #12180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests β π’ Thoughts on this report? Let us know! |
r00gm
changed the title
Pay 2373 virtual schema clean up
perf(editor): SchemaView performance improvement by β90% π
Dec 12, 2024
mutdmour
previously approved these changes
Dec 12, 2024
|
n8nΒ Β Run #8317
Run Properties:Β
|
Project |
n8n
|
Branch Review |
pay-2373-virtual-schema-clean-up
|
Run status |
Β PassedΒ #8317
|
Run duration | 04m 41s |
Commit |
0f2a38abd4: π³ π₯οΈ browsers:node18.12.0-chrome107 π€ r00gm ποΈ e2e/*
|
Committer | r00gm |
View all properties for this run βοΈ |
Test results | |
---|---|
Β Failures |
0
|
Β Flaky |
2
|
Β Pending |
0
|
Β Skipped |
0
|
Β Passing |
480
|
View all changes introduced in this branch βοΈ |
mutdmour
approved these changes
Dec 12, 2024
β All Cypress E2E specs passed |
Merged
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Public release of the performance improvements to the SchemaView in the Node Viewer
Remove the environment variable gating the feature from the public.
For details about the implementations please refer to: #11694
The difference in performance is calculated between the previous and current implementation with a volume of around 23k key - values
Memory usage
Rendered DOM nodes
Related Linear tickets, Github issues, and Community forum posts
PAY-2373
PAY-2225
PAY-1900
#11878
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)