Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Render sanitized HTML content in toast messages #12139

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Dec 10, 2024

Summary

Toast messages that contained HTML were sanitized but not appropriately rendered.

Related Linear tickets, Github issues, and Community forum posts

PAY-2340

PAY-1929

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for making it more consistent.

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Dec 11, 2024

n8n    Run #8281

Run Properties:  status check passed Passed #8281  •  git commit a5db7060e5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-2340-community-edition-license-confirmation-message-has-incorrect
Run status status check passed Passed #8281
Run duration 04m 29s
Commit git commit a5db7060e5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@cstuncsik cstuncsik merged commit 0468945 into master Dec 11, 2024
37 checks passed
@cstuncsik cstuncsik deleted the pay-2340-community-edition-license-confirmation-message-has-incorrect branch December 11, 2024 09:11
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
@janober
Copy link
Member

janober commented Dec 11, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants