fix(core): Make sure task runner exits #12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have for whatever reason (e.g. bug in our code) pending callbacks or promises, nodejs won't exit cleanly. This introduces a shutdown timer that makes sure task runner will exit eventually.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-412-runner-doesnt-die-if-it-has-pending-callbacks-or-promises
|
| Run status |
|
| Run duration | 04m 29s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
tomi
added
the
release/backport
tomi
deleted the
cat-412-runner-doesnt-die-if-it-has-pending-callbacks-or-promises
branch
tomi
added a commit
that referenced
this pull request
Dec 10, 2024
Merged
tomi
added a commit
that referenced
this pull request
Dec 10, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we have for whatever reason (e.g. bug in our code) pending callbacks or promises, nodejs won't exit cleanly. This introduces a shutdown timer that makes sure task runner will exit eventually.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-412/runner-doesnt-die-if-it-has-pending-callbacks-or-promises
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)