Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send and wait operation - freeText and customForm response types #12106

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Dec 9, 2024

Summary

For sendAndWait operation added two new response mods - freeText and customForm

  • freeText simplified version of customForm that allows user to send custom text response
  • customForm allows to define form that could be filled by user allowing to receive more structured data
    image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2092/send-message-and-wait-for-response

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Dec 9, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/utils/sendAndWait/utils.ts 85.96% 6 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@michael-radency michael-radency changed the title feat: Send and wait operation - free text response feat: Send and wait operation - freeText and customForm response types Dec 12, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 16, 2024

n8n    Run #8356

Run Properties:  status check passed Passed #8356  •  git commit bbcdb2373e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2092-respond-to-chat-and-wait-for-response
Run status status check passed Passed #8356
Run duration 04m 37s
Commit git commit bbcdb2373e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

@ShireenMissi ShireenMissi force-pushed the node-2092-respond-to-chat-and-wait-for-response branch from 82ebdbf to bbcdb23 Compare December 16, 2024 15:02
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit e98c7f1 into master Dec 16, 2024
37 checks passed
@ShireenMissi ShireenMissi deleted the node-2092-respond-to-chat-and-wait-for-response branch December 16, 2024 15:30
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants