fix(editor): Don't reset all Parameter Inputs when switched to read-only #12063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
OlegIvaniv
approved these changes
Dec 5, 2024
mutdmour
reviewed
Dec 5, 2024
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Got released with |
ivov
pushed a commit
that referenced
this pull request
Dec 6, 2024
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original code is a bit too wide and ends up resetting previously set values on the resource mapper. We narrow it here to suit the specific use case and behavior today, and will determine the proper way to differentiate properties in a follow up.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2974/resource-mapper-values-are-emptied-when-refreshing-the-columns
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)