Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix switching from v2 to v1 #12050

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Dec 4, 2024

Summary

When switching from v2 to v1 as a new user, you would instantly get migrated to v2 first time you load v1

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7924/fix-switching-canvas-version-from-v2-to-v1-for-new-users

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Dec 4, 2024
@alexgrozav alexgrozav added the release/backport Changes that need to be backported to older releases. label Dec 4, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 4, 2024
Copy link

cypress bot commented Dec 4, 2024

n8n    Run #8214

Run Properties:  status check passed Passed #8214  •  git commit c0f4f3e988: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review fix-canvas-v2-migration
Run status status check passed Passed #8214
Run duration 04m 48s
Commit git commit c0f4f3e988: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ All Cypress E2E specs passed

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexgrozav alexgrozav merged commit 5c76de3 into master Dec 4, 2024
37 checks passed
@alexgrozav alexgrozav deleted the fix-canvas-v2-migration branch December 4, 2024 17:22
ivov pushed a commit that referenced this pull request Dec 5, 2024
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
@janober
Copy link
Member

janober commented Dec 5, 2024

Got released with [email protected]

ivov pushed a commit that referenced this pull request Dec 6, 2024
This was referenced Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants