Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix canvas keybindings using splitter keys such as zooming using + key #12022

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Dec 3, 2024

Summary

Addresses useKeybindings scenarios where shortcuts use one of the splitters (+_-).

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-382/community-issue-the-key-on-the-numeric-keypad-shrinks-the-canvas
Closes #11964

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Dec 3, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😄

Copy link

cypress bot commented Dec 3, 2024

n8n    Run #8197

Run Properties:  status check passed Passed #8197  •  git commit 89dfeabb83: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-382-community-issue-the-key-on-the-numeric-keypad-shrinks-the
Run status status check passed Passed #8197
Run duration 04m 47s
Commit git commit 89dfeabb83: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Dec 3, 2024

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 6af9c82 into master Dec 4, 2024
37 checks passed
@alexgrozav alexgrozav deleted the cat-382-community-issue-the-key-on-the-numeric-keypad-shrinks-the branch December 4, 2024 07:35
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
@janober
Copy link
Member

janober commented Dec 4, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "+" key on the numeric keypad zoom out the canvas.
3 participants