Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MailerLite Node): Update node to support new api #11933

Merged
merged 16 commits into from
Dec 16, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Nov 27, 2024

Summary

This updates the MailerLite node to use the new API instead of the classic API, As part of this change multiple issues have been fixed.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1743/mailterlite-parent-ticket
https://community.n8n.io/t/error-mailerlite-endpoint-not-found-on-trigger/26374
Closes #8555
Closes #10020

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node labels Nov 27, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 29, 2024

n8n    Run #8346

Run Properties:  status check passed Passed #8346  •  git commit c1de64da57: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-1743-mailterlite-parent-ticket
Run status status check passed Passed #8346
Run duration 04m 43s
Commit git commit c1de64da57: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit d6b8e65 into master Dec 16, 2024
37 checks passed
@Joffcom Joffcom deleted the node-1743-mailterlite-parent-ticket branch December 16, 2024 13:44
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MailerLite nodes return wrong subscriber ID Mailerlite endpoint is giving 404
3 participants