Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Execute Workflow Node): Modify execute workflow parameters #11830

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(Execute Workflow Node): Modify execute workflow parameters #11830

merged 1 commit into from
Nov 21, 2024

Conversation

igatanasov
Copy link
Contributor

@igatanasov igatanasov commented Nov 21, 2024 •
edited
Loading

Summary

Remove callout for Execute Workflow Trigger output.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2896/execute-workflow-node-new-node-version-ui-update

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@igatanasov igatanasov self-assigned this Nov 21, 2024
@igatanasov igatanasov added the feature Large self-contained feature label Nov 21, 2024
@igatanasov igatanasov changed the title modify execute workflow parameters feat(nodes): Modify execute workflow parameters Nov 21, 2024
@igatanasov igatanasov changed the title feat(nodes): Modify execute workflow parameters feat(Execute Workflow Node): Modify execute workflow parameters Nov 21, 2024
@igatanasov igatanasov force-pushed the ado-2896-execute-workflow-node-new-node-version-ui-update branch from a5bc5c5 to 8e58bb4 Compare November 21, 2024 13:47
michael-radency
michael-radency approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...base/nodes/ExecuteWorkflow/ExecuteWorkflow.node.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 21, 2024
@igatanasov igatanasov merged commit ae08d70 into feature/sub-workflow-inputs Nov 21, 2024
16 checks passed
@igatanasov igatanasov deleted the ado-2896-execute-workflow-node-new-node-version-ui-update branch November 21, 2024 15:26
MiloradFilipovic added a commit that referenced this pull request Dec 20, 2024
@igatanasov @CharlieKolb
@MiloradFilipovic @netroy
feat: (Execute Workflow Node): Inputs for Sub-workflows (#11830) (#11837
d411663 
)

Co-authored-by: Charlie Kolb <[email protected]>
Co-authored-by: Milorad FIlipović <[email protected]>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
riascho pushed a commit that referenced this pull request Dec 23, 2024
@igatanasov @CharlieKolb
@MiloradFilipovic @netroy @riascho
feat: (Execute Workflow Node): Inputs for Sub-workflows (#11830) (#11837
5fe37c0 
)

Co-authored-by: Charlie Kolb <[email protected]>
Co-authored-by: Milorad FIlipović <[email protected]>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-radency michael-radency michael-radency approved these changes

@MiloradFilipovic MiloradFilipovic Awaiting requested review from MiloradFilipovic

Assignees

@igatanasov igatanasov

Labels
feature Large self-contained feature n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igatanasov @janober @michael-radency