fix(core): Fix crash on webhook when last node did not return data

janober · janober · commit c50d04af9eb0 · 2022-04-02T09:43:51.000+02:00
diff --git a/packages/cli/src/WebhookHelpers.ts b/packages/cli/src/WebhookHelpers.ts
@@ -551,6 +551,7 @@ export async function executeWebhook(
 						if (returnData.data!.main[0]![0] === undefined) {
 							responseCallback(new Error('No item to return got found.'), {});
 							didSendResponse = true;
+							return undefined;
 						}
 
 						data = returnData.data!.main[0]![0].json;
@@ -602,11 +603,13 @@ export async function executeWebhook(
 						if (data === undefined) {
 							responseCallback(new Error('No item to return got found.'), {});
 							didSendResponse = true;
+							return undefined;
 						}
 
 						if (data.binary === undefined) {
 							responseCallback(new Error('No binary data to return got found.'), {});
 							didSendResponse = true;
+							return undefined;
 						}
 
 						const responseBinaryPropertyName = workflow.expression.getSimpleParameterValue(

Original file line number	Diff line number	Diff line change
`@@ -551,6 +551,7 @@ export async function executeWebhook(`
`551`	`551`	`if (returnData.data!.main[0]![0] === undefined) {`
`552`	`552`	`responseCallback(new Error('No item to return got found.'), {});`
`553`	`553`	`didSendResponse = true;`
	`554`	`+ return undefined;`
`554`	`555`	`}`
`555`	`556`
`556`	`557`	`data = returnData.data!.main[0]![0].json;`
`@@ -602,11 +603,13 @@ export async function executeWebhook(`
`602`	`603`	`if (data === undefined) {`
`603`	`604`	`responseCallback(new Error('No item to return got found.'), {});`
`604`	`605`	`didSendResponse = true;`
	`606`	`+ return undefined;`
`605`	`607`	`}`
`606`	`608`
`607`	`609`	`if (data.binary === undefined) {`
`608`	`610`	`responseCallback(new Error('No binary data to return got found.'), {});`
`609`	`611`	`didSendResponse = true;`
	`612`	`+ return undefined;`
`610`	`613`	`}`
`611`	`614`
`612`	`615`	`const responseBinaryPropertyName = workflow.expression.getSimpleParameterValue(`