fix(Spotify Node): Fix issue with null values breaking the response (#12080)

Author: Joffcom

Diff for: packages/nodes-base/nodes/Spotify/GenericFunctions.ts

@@ -5,7 +5,7 @@ import type {
 	IHookFunctions,
 	JsonObject,
 	IHttpRequestMethods,
-	IRequestOptions,
+	IHttpRequestOptions,
 } from 'n8n-workflow';
 import { NodeApiError } from 'n8n-workflow';
 
@@ -21,23 +21,23 @@ export async function spotifyApiRequest(
 	query?: IDataObject,
 	uri?: string,
 ): Promise<any> {
-	const options: IRequestOptions = {
+	const options: IHttpRequestOptions = {
 		method,
 		headers: {
 			'User-Agent': 'n8n',
 			'Content-Type': 'text/plain',
 			Accept: ' application/json',
 		},
 		qs: query,
-		uri: uri || `https://api.spotify.com/v1${endpoint}`,
+		url: uri ?? `https://api.spotify.com/v1${endpoint}`,
 		json: true,
 	};
 
 	if (Object.keys(body).length > 0) {
 		options.body = body;
 	}
 	try {
-		return await this.helpers.requestOAuth2.call(this, 'spotifyOAuth2Api', options);
+		return await this.helpers.httpRequestWithAuthentication.call(this, 'spotifyOAuth2Api', options);
 	} catch (error) {
 		throw new NodeApiError(this.getNode(), error as JsonObject);
 	}

Diff for: packages/nodes-base/nodes/Spotify/Spotify.node.ts

@@ -1308,6 +1308,10 @@ export class Spotify implements INodeType {
 					);
 				}
 
+				// Remove null values from the response
+				if (operation === 'getUserPlaylists') {
+					responseData = responseData.filter((item: IDataObject) => item !== null);
+				}
 				const executionData = this.helpers.constructExecutionMetaData(
 					this.helpers.returnJsonArray(responseData as IDataObject[]),
 					{ itemData: { item: i } },

Diff for: packages/nodes-base/nodes/Spotify/__tests__/GenericFunctions.test.ts

@@ -0,0 +1,62 @@
+import type { IExecuteFunctions, IHookFunctions } from 'n8n-workflow';
+import { NodeApiError } from 'n8n-workflow';
+
+import { spotifyApiRequest } from '../GenericFunctions';
+
+describe('Spotify -> GenericFunctions', () => {
+	let mockThis: IHookFunctions | IExecuteFunctions;
+
+	beforeEach(() => {
+		mockThis = {
+			helpers: {
+				httpRequestWithAuthentication: jest.fn(),
+			},
+			getNode: jest.fn().mockReturnValue({}),
+		} as unknown as IHookFunctions | IExecuteFunctions;
+	});
+
+	it('should make a request with the correct options', async () => {
+		const method = 'GET';
+		const endpoint = '/me';
+		const body = {};
+		const query = { limit: 10 };
+		const response = { data: 'test' };
+
+		(mockThis.helpers.httpRequestWithAuthentication as jest.Mock).mockResolvedValue(response);
+
+		const result = await spotifyApiRequest.call(mockThis, method, endpoint, body, query);
+
+		expect(mockThis.helpers.httpRequestWithAuthentication).toHaveBeenCalledWith(
+			'spotifyOAuth2Api',
+			{
+				method,
+				headers: {
+					'User-Agent': 'n8n',
+					'Content-Type': 'text/plain',
+					Accept: ' application/json',
+				},
+				qs: query,
+				url: `https://api.spotify.com/v1${endpoint}`,
+				json: true,
+			},
+		);
+
+		expect(result).toEqual(response);
+	});
+
+	it('should throw a NodeApiError on request failure', async () => {
+		const method = 'GET';
+		const endpoint = '/me';
+		const body = {};
+		const query = { limit: 10 };
+		const error = new Error('Request failed');
+
+		(mockThis.helpers.httpRequestWithAuthentication as jest.Mock).mockRejectedValue(error);
+
+		await expect(spotifyApiRequest.call(mockThis, method, endpoint, body, query)).rejects.toThrow(
+			NodeApiError,
+		);
+
+		expect(mockThis.getNode).toHaveBeenCalled();
+	});
+});