Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event shorthand regex breaking events if attribute value matches event shorthand writing #268

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

rokyed
Copy link
Contributor

@rokyed rokyed commented Nov 27, 2023

event shorthand regex breaking events if attribute value matches event shorthand writing

Description

Current regex hits even values of the attributes when it's not supposed to.

Additional context

I have documented it more here: #267

Problematic REGEX:

Screenshot from 2023-11-27 14-25-23

I fixed it with this:

Screenshot from 2023-11-27 15-44-02


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@rokyed rokyed changed the title fix: event shorthand regex breaking events if attribute value matches… fix: event shorthand regex breaking events if attribute value matches event shorthand writing Nov 27, 2023
@sergejcodes sergejcodes merged commit 432169e into n6ai:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants