Skip to content

Commit e9e83ab

Browse files
committed
Add assertion
1 parent f7679f4 commit e9e83ab

File tree

1 file changed

+5
-0
lines changed
  • x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/permission

1 file changed

+5
-0
lines changed

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/permission/Role.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import java.util.Objects;
3838
import java.util.Set;
3939
import java.util.function.Predicate;
40+
import java.util.stream.Stream;
4041

4142
public interface Role {
4243

@@ -344,6 +345,10 @@ static SimpleRole buildFromRoleDescriptor(
344345
}
345346

346347
for (RoleDescriptor.ApplicationResourcePrivileges applicationPrivilege : roleDescriptor.getApplicationPrivileges()) {
348+
// We don't support concrete privilege names here, only patterns, since these would require looking up the corresponding actions
349+
// from the security index
350+
assert Stream.of(applicationPrivilege.getPrivileges()).noneMatch(ApplicationPrivilege::isValidPrivilegeName)
351+
: "building role from static role descriptor with concrete application privilege names is not supported";
347352
builder.addApplicationPrivilege(
348353
new ApplicationPrivilege(
349354
applicationPrivilege.getApplication(),

0 commit comments

Comments
 (0)