Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tests #161

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Fix/tests #161

wants to merge 10 commits into from

Conversation

jordidj
Copy link
Collaborator

@jordidj jordidj commented Nov 22, 2024

PR description

Fixing GitHub tests

Checklist

  • all tests pass (and for new features, new tests are added)

@jordidj
Copy link
Collaborator Author

jordidj commented Nov 22, 2024

@n-claes Considering you wrote the docs compilation, do you have any idea what is going on here? It's not fixed by rewinding to a sphinx version that used to work.

@jordidj jordidj added bugfix Fixes something that wasn't working deprecations Deprecated features labels Nov 22, 2024
@n-claes
Copy link
Owner

n-claes commented Nov 23, 2024

@jordidj this looks like a change in config settings for Sphinx but I'm not entirely sure. Are you able to generate the docs locally, either through the script or manually? I'll have a look at the issue as well

@jordidj
Copy link
Collaborator Author

jordidj commented Nov 26, 2024

Everything is passing now, though I'm unsure why the order of extensions matters for sphinx. Maybe it is also time to run the tests on more recent Python versions if vital packages are dropping support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes something that wasn't working deprecations Deprecated features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants