remove q since node ^4.x; do not fail when try to download non existent file

Author: wkrueger

.gitignore

@@ -32,3 +32,5 @@ file1.js
 file2.js
 .nsmockup
 .nscabinet
+.idea
+test/_input

README.md

@@ -20,10 +20,10 @@ _PS: This is actually also a gulp plugin._
 
 ```javascript
 var nscabinet = require('nscabinet');
-gulp.src('myProject/dist/**/*.js').pipe(nscabinet());
+gulp.src('myProject/dist/**/*.js').pipe(nscabinet({ rootPath : '/Templates' }));
 ```
 
-## Input options
+## Accepted input ways
 
 The parameters may be stored in config files, in environment variables, or passed directly.
 
@@ -43,6 +43,24 @@ For instance, let's say you call `nscabinet({ account : '1234' })`. Even if no e
 
 For more info see [nsconfig](https://github.com/suiteplus/nsconfig).
 
+## Common parameters
+
+The following parameters are common through most of the methods:
+
+__Connection__
+
+ * `realm` defaults to `netsuite.com`.
+
+ * `role` defaults to the account's default role.
+
+ * `deployment` defaults to 1.
+
+__Path__
+
+ * `rootPath` sets the root path on the server. Defaults to `/SuiteScripts`. Must begin with `/`.
+
+Example: Upload file with path `img/image.jpg` with rootPath `/Templates` will "upsert" the file
+onto '/Templates/img/image.jpg'.
 
 ## nscabinet.upload
 
@@ -65,14 +83,6 @@ gulp.src('foo.js')
 
 ```
 
- * `realm` defaults to `netsuite.com`.
-	
- * `role` defaults to the account's default role.
-	
- * `deployment` defaults to 1.
-	
- * `rootPath` defaults to `/SuiteScripts`. Must begin with `/`.
- 
  * `isonline` (boolean) lets you set the uploaded files to be avaliable
    without login.
 
@@ -86,12 +96,12 @@ nscabinet.download(['MyProject/*.js','/Web Site Hosting Files/My Site/*.html'])
 
   * `files` file selector (one or many).
 
-    * `*` is accepted on the file part, which is replaced by `%` on the underlying netsuite file search.
+    * `*` is accepted on the file part. The restlet then runs a file search in which `*` is replaced with `%`.
 
     * Paths are also relative to `opts.rootPath`. If a file selector begins with `/`, files will be queried
       by absolute path in netsuite, but saved locally inside the `cabinet_root` folder.
 
-  * `opts` The same options as seen in upload.
+  * `opts` Common options.
 
 
 ## nscabinet.url ( file : string , [opts] ) : Promise[string]

package.json

@@ -31,7 +31,6 @@
   "homepage": "https://github.com/suiteplus/nscabinet#readme",
   "dependencies": {
     "nsconfig": "^0.3.0",
-    "q": "^1.4.1",
     "request": "^2.64.0",
     "through2": "^2.0.0",
     "vinyl": "^1.0.0",
@@ -50,7 +49,6 @@
     "gulp-mocha": "^2.1.3",
     "gulp-plumber": "^1.0.1",
     "nsmockup": "^0.8.0",
-    "q": "^1.4.1",
     "require-dir": "^0.3.0",
     "should": "^7.1.0"
   }

restlet/nscabinet-restlet.js

@@ -55,6 +55,7 @@ var download = function (datain) {
         datain.files = [datain.files];
     }
 
+    var errors = [];
     function getFileData(file, info) {
         var contents = file.getValue();
 
@@ -100,12 +101,19 @@ var download = function (datain) {
             outfiles = outfiles.concat(addFiles);
             //case 2: direct load
         } else {
-            var file = nlapiLoadFile(info.pathabsolute.substr(1));
-            outfiles = outfiles.concat([getFileData(file, info)]);
+            try {
+                var file = nlapiLoadFile(info.pathabsolute.substr(1));
+                outfiles = outfiles.concat([getFileData(file, info)]);
+            } catch (e) {
+                errors.push(e);
+            }
         }
     });
 
-    return {files: outfiles};
+    var out = {files: outfiles};
+    if (errors.length) out.error = errors;
+    return out;
+
 };
 
 

src/nscabinet.js

@@ -4,8 +4,7 @@ var request = require('request'),
     through = require('through2'),
     vinyl = require('vinyl'),
     nsconfig = require('nsconfig'),
-    path = require('path'),
-    q = require('q');
+    path = require('path');
 
 var PARAMS_DEF = [
     {name: 'rootPath', def: '/SuiteScripts'},
@@ -55,7 +54,7 @@ function upload (params) {
 
 
 module.exports.download = download;
-function download (files,params) {
+function download (files,params,info) {
     params = checkParams(params);
     var toRequest = _requestOpts(params);
     toRequest.json = {
@@ -72,9 +71,19 @@ function download (files,params) {
         function flush(cb) {
             var data = JSON.parse(buffer);
             if (data.error) {
-                console.error(data.error.message);
-                this.emit('error',data.error);
-                return;
+                data.error = data.error.map( err => {
+                    try {
+                        return JSON.parse(err)
+                    }catch(e) {
+                        //keep as it came
+                        return err;
+                    }
+                } );
+                data.error.forEach( e => console.error('RESTLET ERROR: ' + (e.details || e.message || e)) );
+                info = info || {};
+                info.errors = info.errors || [];
+                info.errors = info.errors.concat(data.error);
+                //this.emit('error',data.error);
             }
             data.files = data.files || [];
             data.files.forEach( file => {
@@ -93,6 +102,7 @@ function download (files,params) {
 }
 
 /* STUB */
+/*
 module.exports.deleteFolder = deleteFolder;
 function deleteFolder (folders, params) {
     params = checkParams(params);
@@ -104,6 +114,7 @@ function deleteFolder (folders, params) {
         folders : folders
     };
 }
+*/
 
 
 module.exports.checkParams = checkParams;
@@ -125,11 +136,12 @@ function url(path, params) {
         action :  'url' ,
         path : params.rootPath.substr(1) + '/' + path
     };
-    var deferred = q.defer();
-    request( toRequest , (err,resp,body) => {
-        deferred.resolve(`https://system.${params.realm}${body.url}`);
+    return new Promise((resolve,reject) => {
+        request( toRequest , (err,resp,body) => {
+            if (err) return reject(err);
+            resolve(`https://system.${params.realm}${body.url}`);
+        });
     });
-    return deferred.promise;
 }
 
 

test/nscabinet-test.js

@@ -165,5 +165,22 @@ describe('nscabinet:', function() {
     });
     */
 
-    
+
+    it('try to download 2 files, the 1st does not exist. Emit warning but still download the second', function(done){
+        var content = randContent();
+        fs.writeFileSync('test/_input/cnt1.txt', content);
+        vinyl.src(['test/_input/cnt1.txt']).pipe(nscabinet()).on('finish', () => {
+            nscabinet.download(['test/_input/cnt2.txt','test/_input/cnt1.txt'])
+                .pipe(vinyl.dest('test/_output'))
+                .on('finish' , () => {
+                    should(fs.existsSync('test/_output/test/_input/cnt1.txt')).be.true();
+                    should(fs.readFileSync('test/_output/test/_input/cnt1.txt').toString())
+                        .be.equal(content);
+                    done()
+                });
+        });
+
+    });
+
+
 });