Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default all options to 'no' #4

Open
mziwisky opened this issue Feb 15, 2015 · 2 comments
Open

Default all options to 'no' #4

mziwisky opened this issue Feb 15, 2015 · 2 comments

Comments

@mziwisky
Copy link
Owner

I'd like to default everything to 'no', which seems like it would allow fewer false positives (in this case, "false N/As") to slip by, but when we make initial status for all options 'false', we get a weird focus issue -- upon opening the review menu, the textarea looks like it has focus, but it only "accepts" the first keystroke. subsequent keystrokes don't fill in the textarea (even tho it looks like it's still focused), and you're forced to click it before you get your cursor back in there.

@MrGrinst
Copy link
Contributor

MrGrinst commented Aug 20, 2019

This can be closed out if #6 merges. It doesn't default to 'no' but it allows repos that want to opt-in to the "default no" behavior to do so easily.

@mziwisky
Copy link
Owner Author

@MrGrinst have you checked whether opting in repros the described issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants