-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to not focus after flip #2
Comments
@mzabriskie how about it? Would you consider a PR for this issue? |
The focus is done for the sake of accessibility. I am reluctant to break the use case for screen readers. I understand your PR would be done as an optional prop, but I wonder in your use case where the focus should be, and how it affects a11y. |
I see your point about a11y now. If I understand correctly, one example could be: |
I guess I don't fully understand your use case. It sounds like you are showing a loading image while your data loads, to indicate that something is happening. Why wouldn't this same message need to be conveyed to someone with an impairment? Also if the data is still loading, what are they reading? |
First, I'll mention that this is not deal breaker for me. I see the value in your points and wouldn't want to hurt a11y. And now to answer your questions... |
fix: Protect against unmounting
Are you still interested in having an option to disable focus on flip? I can open a PR for that. I know it has been a while, but it would still be cool to have it ! |
Hi, I was glad to find this component, it's pretty sweet - thanks!
I'd like to add the option to avoid focusing after flipping.
I will gladly work on a PR for this if this is something you may be interested in merging.
P.S.
Here's my use case:
I'm using the flip card show a placeholder image until all my data is ready. When the data is ready, I flip the card to reveal the final image. So focusing on the image is not a desired effect here.
The text was updated successfully, but these errors were encountered: