Add transform-inline-environment-variables Babel plugin#445
Merged
STRML merged 1 commit intoreact-grid-layout:masterfrom Dec 6, 2019
erictooth:master
Merged
Add transform-inline-environment-variables Babel plugin#445STRML merged 1 commit intoreact-grid-layout:masterfrom erictooth:master
STRML merged 1 commit intoreact-grid-layout:masterfrom
erictooth:master
Conversation
Collaborator
|
Fair enough, thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cjs and esm builds introduced 4.1.0 contain references to process.env.DRAGGABLE_DEBUG, which is not necessarily replaced by all bundlers out of the box.
My suggestion would be to do the same thing as your Webpack configuration, and rewrite process variables at build time using babel-plugin-transform-inline-environment-variables.