pass the bounded x and y in the DraggableData#226
Closed
edeustace wants to merge 4 commits intoreact-grid-layout:masterfrom
Closed
pass the bounded x and y in the DraggableData#226edeustace wants to merge 4 commits intoreact-grid-layout:masterfrom
edeustace wants to merge 4 commits intoreact-grid-layout:masterfrom
Conversation
|
@STRML, can these changes be added to the next release? |
Closed
|
@STRML, could you please rerun tests? I think the failed checks may be an environment issue. |
STRML
added a commit
that referenced
this pull request
Aug 21, 2017
Collaborator
|
Ported into 55f701e - thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into an issue where I was trying to synch a component's position with another one that was being dragged via a
Draggable, I was usingonDragfor this.It works fine until you go outside the bounds at which point the x/y would fall out of synch. This PR returns the bounded x/y (set in
newState) inDraggableDataback to the callback.