Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function: CS104_Slave_startThreadless() may has a bug in it #92

Open
tangkai-prc opened this issue Apr 30, 2021 · 1 comment
Open

function: CS104_Slave_startThreadless() may has a bug in it #92

tangkai-prc opened this issue Apr 30, 2021 · 1 comment

Comments

@tangkai-prc
Copy link

when
#if (CONFIG_USE_THREADS == 1)
self->isThreadlessMode = true;
#endif
is this a clerical error when USE_THREADS == 1? I think it is be better return when CONFIG_USE_THREADS == 1 as below:
#if (CONFIG_USE_THREADS == 1)
self->isThreadlessMode = false;
self->isStarting = false;
return ;
#endif

@mzillgith
Copy link
Contributor

The idea is that when compiling the library with thread support (CONFIG_USE_THREADS) it is still possible using it without the library creating its own threads. Not sure if there are many use cases for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants