Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 8.x #34

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link
Contributor

ESLint v8.0.0 is released 🎉

devDependency compatibility with ESLint 8:


BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0

Closes #33

BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
Copy link

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What in this PR is actually needed to support ESLint 8?

Much if this PR seems like general maintenance and that's best kept separate from the core change to make the core change as small and focused and reviewable and mergeable as possible.

Eg: Changing the CI definition more than explicitly needed while introducing other changes makes it harder to know if this breaks anything or whether the CI definition isn't testing properly anymore.

"eslint": ">=5"
"eslint": "^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't needed to support ESLint 8?

@@ -19,15 +19,15 @@
"./package.json": "./package.json"
},
"dependencies": {
"eslint-visitor-keys": "^2.0.0"
"eslint-visitor-keys": "^3.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this update needed for ESLint 8? Can't find anything that says so in either of diff or releases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's developed to be compatible with ESLint 8, so that's why I updated

package.json Show resolved Hide resolved
@MichaelDeBoey
Copy link
Contributor Author

For people watching this PR: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/eslint-utils

@mysticatea We would still love to move the original repo to the new https://github.com/eslint-community though.


This PR is released in @eslint-community/eslint-utils v4.1.0
https://github.com/eslint-community/eslint-utils/releases/tag/v4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
2 participants