Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core #27

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Core #27

wants to merge 7 commits into from

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Apr 15, 2020

Fixes #21 and #23

  • Remove non-core rules (vue, ts, eslint-comments, eslint-plugin, node, prettier)
  • Remove all configs except as needed to cover project-defined rules
  • Linting as per latest prettier
  • Testing: Change from broken use of "category" to relying on custom meta.version for determination of ES version (eslint docs allowing for customization within meta)
  • Testing: improve coverage slightly
  • Docs: fix jsdoc description
  • Update devDeps

Note that this is not a PR to be accepted here, but a PR to suggest a separate repository, @mysticatea/eslint-plugin-core (or however you'd want to name it). That is why I've submitted it as a draft, but it should be ready for review.

If you are amenable to setting up such a separate repository, e.g., with the contents of this PR, I could look to amending the current code of @mysticatea/eslint-plugin proper to make use of this proposed @mysticatea/eslint-plugin-core project.

brettz9 added 3 commits April 15, 2020 12:03
…e, prettier)

- Remove all configs except as needed to cover project-defined rules
- Testing: Change from broken use of "category" to relying on custom `meta.version` for determination of ES version (eslint docs allowing for customization within `meta`)
- Linting as per latest prettier
- Update devDeps
@brettz9
Copy link
Contributor Author

brettz9 commented Apr 15, 2020

Btw, while there were some other aspects of your config which might be of general interest, such as:

  • Combining globals with ecmaVersion
  • Defaults for config files
  • Disabling of certain CJS globals in modules
  • Expanding of node plugin's tryExtensions

...I didn't add these as:

  1. I thought this proposed core package should be granular in being focused on rules.
  2. I thought they could be added to their own separate package if desired (and are not too difficult to add manually in any case), allowing those who didn't want your custom rules for some reason or other to also benefit from them.

@brettz9
Copy link
Contributor Author

brettz9 commented Apr 25, 2020

@mysticatea : Hi... Was just wondering if you were open in principle to this concept of a separate core plugin having the custom rules only (also asked for in #23) from which @mysticatea/eslint-plugin could derive? If not, I suppose I could just publish this myself, but it'd be nice to get the benefit of any new rules you might wish to add in the future if you were open to maintaining it. Thanks!

- Add coverage to ignore and lint all by default (adding to ignore allows discovery by IDEs)
@brettz9
Copy link
Contributor Author

brettz9 commented Feb 14, 2021

I've published my own @brettz9/eslint-plugin which just extracts the bare rules (and the es5 and es6 configs), so if you aren't planning on developing this further on your own, you're of course welcome to close.

MichaelDeBoey added a commit to MichaelDeBoey/eslint-plugin-mysticatea that referenced this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"all" config
1 participant