Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"all" config #21

Open
brettz9 opened this issue Jun 24, 2019 · 3 comments · May be fixed by #27
Open

"all" config #21

brettz9 opened this issue Jun 24, 2019 · 3 comments · May be fixed by #27

Comments

@brettz9
Copy link
Contributor

brettz9 commented Jun 24, 2019 •
edited
Loading

Hi,

I'm using your useful plugin from my config eslint-config-ash-nazg and was wondering if you might add a config which includes all of the rules of this plugin (but no other rules from eslint or other plugins/configs). (And one which preferably auto-adds: plugins: ["@mysticatea"]...)

This would assist me now and into the future for succinctly making clear that I am normally tracking against your plugin though also forcing me to review any new rules you may add (and for auto-comparing my config to the configs I am extending).

Thanks!
@mysticatea
Copy link
Owner

Thank you for your proposal.

If the purpose was comparison, I wonder if Object.keys(require("@mysticatea/eslint-plugin").rules) is enough?

(as a side note, for a reference, there is an RFC for ConfigTester that can check a config contains all rules or not: eslint/rfcs#27)

@brettz9
Copy link
Contributor Author

brettz9 commented Jun 24, 2019

Yeah sorry, I amended my original post to clarify my intent. While it might streamline my comparing (since I'm comparing with configs in most cases), I'd really just like to make my source clearer and have one extends for either an "all" or "recommended" rule. I figure those already familiar with other configs such as yours won't need to be troubled to see which individual ones I'm using if I am merely extending, and then I'd also get the benefit of any other rules you added (though I review updates to affirm I agree with the additions, I tend to find that smart people's "recommended" rules are worth my being forced to examine for inclusion (unlike if I only whitelisted individual rules), and it'd be nice not to have to add rules individually with every update except to override as I felt necessary).

Great to know about the rfc, I hope to take a closer look as I have a chance.

@brettz9 brettz9 linked a pull request Apr 15, 2020 that will close this issue
Draft
MichaelDeBoey added a commit to MichaelDeBoey/eslint-plugin-mysticatea that referenced this issue Nov 14, 2022
@MichaelDeBoey
feat: upgrade prettier to v2 (mysticatea#21)
668d46e 
* feat: upgrade `prettier` to v2

BREAKING CHANGE: `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020`, `es2021` & `es2022` configs will now report for their changed default values. For more info check their [release notes](https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes)

* chore: fix ESLint errors

* chore: run Prettier on codebase
@MichaelDeBoey
Copy link

Hi @brettz9!

Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-mysticatea

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core brettz9/eslint-plugin
3 participants
@brettz9 @mysticatea @MichaelDeBoey