-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): add tests for ESLint 7 #224
base: master
Are you sure you want to change the base?
Conversation
Any plans to progress this feature/pull request? |
@weyert We still have to wait for mysticatea/eslint-utils#7 before we can start going forward with this one 🙂 |
2c341ff
to
4b62527
Compare
Since all tests are green for ESLint 7.x, I think we can merge this one without mysticatea/eslint-utils#7 being merged 🙂 |
Howdy! any plans for merging this PR? I see it was ready to be merged 22 days ago |
@mysticatea All tests are green (locally), so I think we can merge this one 🙂 |
a66fac4
to
6a71e0b
Compare
Would it be possible to drop this down from a daunting 42 file change to something more narrowed and easier to review? Looks like most of the diff is to sort object definitions by key and to eg. restructure the way that the CI setup is done? (Moving from an exclude to an include) To really make reviewing and merging simpler, keeping the diff to a minimal is good 👍 |
@voxpelli Most of the changes are due to updating Would it help if I created separate commits in order to understand a bit better what's happening? |
The smaller chunks the easier to review and to understand the scope, so yes, one PR per such scope would be nice 👍 |
@voxpelli As I said before: doing everything in separate PRs won't be possible, as of the breaking changes But I can create separate commits if that makes it easier for you |
# Conflicts: # package.json
BREAKING CHANGE: Requires Node@^10.0.0 || ^12.0.0 || >=14.0.0
# Conflicts: # package.json
6a71e0b
to
49ef331
Compare
* feat: add `name` to flat configs refs: eslint/eslint#18252 * fix: npm install error
ESLint v7.0.0 is released 🎉
Dependencies should be compatible with ESLint 7 too before we can merge this one:
eslint-plugin-es
(Support ESLint 7.x eslint-plugin-es#29)v3.0.1
eslint-utils
(Support ESLint 7.x eslint-utils#6)v3.0.0
devDependency compatibility with ESLint 7:
@mysticatea/eslint-plugin
(Support ESLint 7.x eslint-plugin#28)Closes #223
This branch is dependent on #305, #306, #307, #308 & #309