From 55c54bdc5b7de6b0eda210bd1c573ba19eeeb895 Mon Sep 17 00:00:00 2001 From: Douglas Christopher Wilson Date: Wed, 1 Jun 2016 00:19:05 -0400 Subject: [PATCH] Fix handshake inactivity timeout on Node.js v4.2.0 fixes #1223 fixes #1236 fixes #1239 fixes #1240 fixes #1241 fixes #1252 --- .travis.yml | 1 + Changes.md | 1 + lib/protocol/sequences/Sequence.js | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 4ce8540e6..1c8dbf58e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,7 @@ node_js: - '1.8' - '2.5' - '3.3' + - '4.2.0' # Test timers regression - '4.4' - '5.11' - '6.2' diff --git a/Changes.md b/Changes.md index 6bf9c8eb2..d50cbdd21 100644 --- a/Changes.md +++ b/Changes.md @@ -9,6 +9,7 @@ you spot any mistakes. * Add `POOL_CLOSED` code to "Pool is closed." error * Add `POOL_CONNLIMIT` code to "No connections available." error #1332 * Fix edge cases constructing long stack traces #1387 +* Fix handshake inactivity timeout on Node.js v4.2.0 #1223 #1236 #1239 #1240 #1241 #1252 * Fix Query stream to emit close after ending #1349 #1350 * Fix type cast for BIGINT columns when number is negative #1376 * Performance improvements for array/object escaping in SqlString #1331 diff --git a/lib/protocol/sequences/Sequence.js b/lib/protocol/sequences/Sequence.js index 8c6d877fc..5da5a39d0 100644 --- a/lib/protocol/sequences/Sequence.js +++ b/lib/protocol/sequences/Sequence.js @@ -29,7 +29,7 @@ function Sequence(options, callback) { this._idleNext = null; this._idlePrev = null; this._idleStart = null; - this._idleTimeout = undefined; + this._idleTimeout = -1; this._repeat = null; }