Fix for Bug#19857207, EXECUTE ON CALLABLESTATEMENT RESULTS IN ARRAYINDEXOUTOFBOUNDSEXCEPTION.

Change-Id: I1039a26fbc4768e3983cecc1d12bca2fde9fbd37

Author: Axyoan Marcelo

CHANGES

@@ -3,6 +3,8 @@
 
 Version 9.3.0
 
+  - Fix for Bug#19857207, EXECUTE ON CALLABLESTATEMENT RESULTS IN ARRAYINDEXOUTOFBOUNDSEXCEPTION.
+
   - Fix for Bug#117027 (Bug#37415840), Mysql connector use an uneffective way to match numericValue.
 
   - Fix for Bug#19829452, PARAMETER INDEX VALIDATION NOT PROPER IN CALLABLESTATEMENT.

src/main/user-impl/java/com/mysql/cj/jdbc/CallableStatement.java

@@ -2279,7 +2279,18 @@ private void setInOutParamsOnServer() throws SQLException {
 
                         try {
                             setPstmt = this.connection.clientPrepareStatement(queryBuf.toString()).unwrap(ClientPreparedStatement.class);
-                            setPstmt.getQueryBindings().setFromBindValue(0, ((PreparedQuery) this.query).getQueryBindings().getBindValues()[inParamInfo.index]);
+                            int inOutParamIndex = 0;
+                            if (this.paramInfo.placeholderToParameterIndexMap == null) {
+                                inOutParamIndex = inParamInfo.index;
+                            } else {
+                                for (int i = 0; i < this.paramInfo.placeholderToParameterIndexMap.length; i++) {
+                                    if (this.paramInfo.placeholderToParameterIndexMap[i] == inParamInfo.index) {
+                                        inOutParamIndex = i;
+                                        break;
+                                    }
+                                }
+                            }
+                            setPstmt.getQueryBindings().setFromBindValue(0, ((PreparedQuery) this.query).getQueryBindings().getBindValues()[inOutParamIndex]);
                             setPstmt.executeUpdate();
                         } finally {
                             if (setPstmt != null) {

src/test/java/testsuite/regression/CallableStatementRegressionTest.java

@@ -1970,4 +1970,19 @@ public void testBug19829452() throws Exception {
         assertThrows(SQLException.class, () -> testCstmt.getString(0));
     }
 
+    /**
+     * Tests fix for Bug#19857207, EXECUTE ON CALLABLESTATEMENT RESULTS IN ARRAYINDEXOUTOFBOUNDSEXCEPTION.
+     *
+     * @throws Exception
+     */
+    @Test
+    public void testBug19857207() throws Exception {
+        createProcedure("testBug19857207", "(IN a VARCHAR(10),INOUT b VARCHAR(10)) BEGIN SET b = 'data'; END");
+        CallableStatement testCstmt = this.conn.prepareCall("{ CALL testBug19857207('a', ?) }");
+        testCstmt.setString(1, "b");
+        testCstmt.registerOutParameter(1, java.sql.Types.VARCHAR);
+        testCstmt.execute();
+        assertEquals("data", testCstmt.getString(1));
+    }
+
 }