Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main_start instances unable to start/stop gracefully #15

Open
myrakrusemark opened this issue Apr 7, 2023 · 1 comment
Open

Main_start instances unable to start/stop gracefully #15

myrakrusemark opened this issue Apr 7, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@myrakrusemark
Copy link
Owner

Main_start instances are subprocesses that require running self.main() to start, and self.close() to stop.

2/3 available plugins (Daisy, Noaa) have been observed to start/stop gracefully. The issue seems to be in main.py.

I think main.py is looking for instances added to hook_instances["Main_start"], and should instead be looking at whether available_module says its enabled, then main/close the module accordingly.

@myrakrusemark myrakrusemark added bug Something isn't working help wanted Extra attention is needed labels Apr 7, 2023
@myrakrusemark
Copy link
Owner Author

A lot of work done in this direction but not tested.
Final implementation will utilize self.close()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant