-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min and max duration filters #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxpv
reviewed
Nov 23, 2022
Also needs rebase |
I've removed the helper, as suggested :) Here is the overview of the log file, in debug mode: DEBU[2022-11-23T20:07:49+02:00] -> SomeYoutubeChannel (update '@every 4h0m0s')
INFO[2022-11-23T20:07:49+02:00] -> updating https://www.youtube.com/user/SomeYoutubeChannel feed_id=SomeYoutubeChannel format=audio quality=low
DEBU[2022-11-23T20:07:49+02:00] building feed
DEBU[2022-11-23T20:07:49+02:00] Expected to make 1 API calls to get the descriptions for 4 episode(s).
DEBU[2022-11-23T20:07:49+02:00] received 4 episode(s) for "SomeYoutubeChannel"
DEBU[2022-11-23T20:07:49+02:00] successfully saved updates to storage
INFO[2022-11-23T20:07:49+02:00] downloading episodes page_size=4
INFO[2022-11-23T20:07:49+02:00] skipping due to regexp mismatch episode_id=QSUyW2SYxyz filter=title
INFO[2022-11-23T20:07:49+02:00] skipping due to duration filter (1616s) episode_id=Q5a81JNaxyz filter=min_duration
INFO[2022-11-23T20:19:51+02:00] skipping due to duration filter (4903s) episode_id=mDJ65ortxyz filter=max_duration
DEBU[2022-11-23T20:07:49+02:00] adding f6Vkhov_xyz ("Some video name") to queue
INFO[2022-11-23T20:07:49+02:00] download count: 1
INFO[2022-11-23T20:07:49+02:00] ! downloading episode https://youtube.com/watch?v=f6Vkhov_xyz episode_id=f6Vkhov_xyz index=0
DEBU[2022-11-23T20:08:50+02:00] copying file episode_id=f6Vkhov_xyz index=0
INFO[2022-11-23T20:08:50+02:00] creating file: /tmp/podsync/data/SomeYoutubeChannel/f6Vkhov_xyz.mp3 name=SomeYoutubeChannel/f6Vkhov_xyz.mp3
DEBU[2022-11-23T20:08:50+02:00] written 71075789 bytes name=SomeYoutubeChannel/f6Vkhov_xyz.mp3
INFO[2022-11-23T20:08:50+02:00] successfully downloaded file "f6Vkhov_xyz" episode_id=f6Vkhov_xyz index=0
INFO[2022-11-23T20:08:50+02:00] downloaded 1 episode(s)
INFO[2022-11-23T20:08:50+02:00] nothing to clean feed_id=SomeYoutubeChannel
DEBU[2022-11-23T20:08:50+02:00] building iTunes podcast feed
INFO[2022-11-23T20:08:50+02:00] creating file: /tmp/podsync/data/SomeYoutubeChannel.xml name=SomeYoutubeChannel.xml
DEBU[2022-11-23T20:08:50+02:00] written 10517 bytes name=SomeYoutubeChannel.xml
DEBU[2022-11-23T20:08:50+02:00] building podcast OPML
INFO[2022-11-23T20:08:50+02:00] creating file: /tmp/podsync/data/podsync.opml name=podsync.opml
DEBU[2022-11-23T20:08:50+02:00] written 130 bytes name=podsync.opml
INFO[2022-11-23T20:08:50+02:00] successfully updated feed in 1m0.980123362s
INFO[2022-11-23T20:08:50+02:00] next update of SomeYoutubeChannel: 2022-11-24 00:07:49 +0200 EET |
mxpv
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use
min_duration
andmax_duration
(in seconds) as filter to detect if we want to download the episode or not.Example of log lines :